Skip to content

build: remove required PAT auth when building a client #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cattyngmd wants to merge 3 commits into
base: mc.1.21.11
Choose a base branch
from
Open

build: remove required PAT auth when building a client #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93d6813
build: remove required PAT auth when building a client
cattyngmd Feb 20, 2026
d08568c
fix: add include to build properly
cattyngmd Feb 20, 2026
7091c2d
docs: update README build path
cattyngmd Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,20 +83,18 @@ The default command prefix is `-`.

1. Clone the repository:

```bash
```sh
git clone https://github.com/NamiDevelopment/Nami.git
cd nami
```
2. In order to get nami-api dependency,you need to configure your PAT-token in your root .gradle/gradle.dependency
2. Build with Gradle:

3. Build with Gradle:

```bash
```sh
./gradlew build
```

The compiled JAR will be located at:
`build/libs/nami-<version>.jar`
`./<project>/build/libs/nami-<version>.jar`

nami-client is packaged with nami-api inside of it.

Expand Down
24 changes: 10 additions & 14 deletions nami-client/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,24 +6,23 @@ plugins {
}

repositories {
maven {
url = uri("https://maven.pkg.github.com/NamiDevelopment/nami")
credentials {
username = project.findProperty("gpr.user") ?: System.getenv("GITHUB_ACTOR")
password = project.findProperty("gpr.key") ?: System.getenv("GITHUB_TOKEN")
}
}

maven { url = "https://maven.fabricmc.net/" }

maven { url = "https://repo.spongepowered.org/maven" }

mavenCentral()

}

loom {
accessWidenerPath = file("src/main/resources/META-INF/nami.accesswidener")

mods {
"nami-api" {
sourceSet project(":nami-api").sourceSets.main
}
"nami-client" {
sourceSet sourceSets.main
}
}
}

processResources {
Expand All @@ -42,7 +41,6 @@ processResources {

group = project.maven_group
version = project.mod_version
def namiApiVersion = project.nami_api

tasks.register("printVersion") {
doLast {
Expand All @@ -56,9 +54,7 @@ dependencies {
modImplementation "net.fabricmc:fabric-loader:${project.loader_version}"
modImplementation "net.fabricmc.fabric-api:fabric-api:${project.fabric_version}"


modImplementation "namidevelopment.kiriyaga:nami-api:${namiApiVersion}"
include "namidevelopment.kiriyaga:nami-api:${namiApiVersion}"
include implementation(project(path: ":nami-api", configuration: "namedElements"))
Copy link
Member

@Kiriyaga7615 Kiriyaga7615 Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe it should be
modImplementation
Include

because with just implementation, this will be incompatible with any fabric mod that uses nami api?

}

java {
Expand Down