-
Notifications
You must be signed in to change notification settings - Fork 214
Itc basis updates #2187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
brtietz
wants to merge
69
commits into
develop
Choose a base branch
from
itc_basis_updates
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Itc basis updates #2187
Changes from all commits
Commits
Show all changes
69 commits
Select commit
Hold shift + click to select a range
f556906
Initial mockups for itc basis and depreciation allocation changes
mjprilliman f7d09fe
Hybrid version of ITC basis page, update depreciation allocations to
mjprilliman 11408d6
Merge branch 'develop' into itc_basis_updates
sjanzou 9b03972
latest api_autogen updates for itc_basis_updates brancch
sjanzou 511d5cd
defaults updates when running test script
sjanzou 0feab1b
Controls on itc and depr page, fix enabling and calculations
mjprilliman 612d6e1
Merge branch 'develop' of https://github.com/NREL/SAM into itc_basis_…
brtietz 22eb434
Clean up a few more things in startup.lk and wind defaults
brtietz 99691ff
Merge branch 'itc_basis_updates' of https://github.com/NREL/SAM into …
brtietz ebf346c
One more round of defaults updates given some changes I hadn't pulled
brtietz 53656b4
Merge branch 'develop' into itc_basis_updates
mjprilliman 06aa0b5
Add depreciation allocation to equations, add calculated versus input
mjprilliman 67bebcd
Merge branch 'develop' of https://github.com/NREL/SAM into itc_basis_…
brtietz 526607b
Combine incentives and depreciation pages
mjprilliman a66b2c0
Merge branch 'itc_basis_updates' of https://github.com/NREL/SAM into …
e700784
Fix show hide for battery
mjprilliman 71c14b6
Merge branch 'itc_basis_updates' of https://github.com/NREL/SAM into …
brtietz 004eb94
Merge branch 'develop' of https://github.com/NREL/SAM into itc_basis_…
brtietz 36687a6
Get single owner hybrids ITC inputs working with the beast
brtietz 7e401c8
working implementation for hybrid single owner, pv-battery, pvwatts b…
brtietz 9653bc9
host developer hybrids and stand alone batteries
brtietz 0c7ba04
Startup.lk revisions for all fin models except commercial
brtietz 4420b9f
Walk back the commercial changes to keep the PR a little smaller
brtietz ce69735
Overwrite all defaults with new UI values
brtietz 7e52ca9
Some UI cleanup, ensure checkboxes don't appear for single techs
brtietz 1cbd5db
UI cleanup, remove manual option
mjprilliman a85bc91
Merge branch 'itc_basis_updates' of https://github.com/NatLabRockies/…
mjprilliman 4e96873
More UI cleanup
mjprilliman 5bcef1e
Defaults update for new itc basis, part 1
brtietz 98cb5ee
Merge branch 'develop' of https://github.com/NREL/SAM into itc_basis_…
brtietz b9c7e7b
Update ITC and PTC qualification for obbba
brtietz ae57861
Test script ow.lk results
brtietz 94bf752
Overwite computed defaults and export API defaults
brtietz b1a83e7
Update residential and commercial depreciation treatments, make hybrid
mjprilliman 13a4e64
Update defaults
mjprilliman 51f86f8
Merge branch 'itc_basis_updates' of https://github.com/NatLabRockies/…
mjprilliman bfdd9c4
Version upgrade script for itc changes
brtietz 1a6b128
Merge branch 'itc_basis_updates' of https://github.com/NREL/SAM into …
brtietz acea351
Merge branch 'develop' into itc_basis_updates
mjprilliman 3edd1de
Merge branch 'develop' of https://github.com/NREL/SAM into itc_basis_…
brtietz 8265237
Resolve merge conflicts from develop, re run test outputs with new de…
brtietz b896172
Merge branch 'develop' of https://github.com/NREL/SAM into itc_basis_…
brtietz 5d087ca
Merge branch 'itc_basis_updates' of https://github.com/NatLabRockies/…
mjprilliman 91d1fc1
Add incentives and depreciation changes to IPH models
mjprilliman 7af9ce7
Merge branch 'develop' of https://github.com/NREL/SAM into itc_basis_…
brtietz 4850df3
Merge branch 'itc_basis_updates' of https://github.com/NREL/SAM into …
brtietz d28a53f
Merge branch 'trough_optical_table' of https://github.com/NREL/SAM in…
brtietz f83c696
Merge branch 'develop' of https://github.com/NREL/SAM into itc_basis_…
brtietz 10cb25a
Get the new itc code working with residential. Who knows what else br…
brtietz 7aa2b91
Api changes for new defaults
brtietz 031bf05
New cashloan variables for more complete depreciation options
brtietz 504f9a3
Merge branch 'develop' of https://github.com/NREL/SAM into itc_basis_…
brtietz 7aa31ea
Work on more subtle defaults conflicts post-merge
brtietz 7709536
Initial paulification of deprecation/ITC UI
cpaulgilman a7c04a1
Finish depreciation/ITC UI cleanup
cpaulgilman 3818977
Update help file structure for new ITC/depreciation UI
cpaulgilman 8afceb5
Update defaults for ITC/depreciation UI cleanup
cpaulgilman ed1db74
Fix broken defaults
cpaulgilman 807479d
Fix more defaults
cpaulgilman 6c753a4
Final pesky hybrid defaults
cpaulgilman 9df5a5c
Downstream api and test defaults updates
brtietz 406abc9
Update callbacks for MEWave Battery
brtietz e61bd7e
Send to excel updates for new commercial depreciation code
brtietz 4612206
Update test results for mewave battery
brtietz 3829ed4
Unify commercial depreciation on new pages
brtietz 57bd23b
Version upgrade for cashloan
brtietz 74cf676
Add new page for fuel cell itc qualification
brtietz 51a00cf
Merge branch 'develop' of https://github.com/NREL/SAM into itc_basis_…
brtietz 17eb8d6
API changes - feel free to discard or merge with #2187
sjanzou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of large surface area changes for the battery - is that expected?