Open
Conversation
c-m-hunt
commented
Oct 5, 2019
c-m-hunt
commented
- Use Twitter API rather than scraping. Ensures we can always get media if available
- Amend size check to always get to under threshold
NathanDeMaria
approved these changes
Oct 24, 2019
| ## Setup and Installation | ||
| ### Set up Twitter creds | ||
| * Generate access token. Full instructions at https://developer.twitter.com/en/docs/basics/authentication/guides/access-tokens | ||
| * Copy `twitter_creds.dist.json` to `twitter_creds.json` |
Owner
There was a problem hiding this comment.
I had to put it in data/twitter_creds.json. Sound right?
Author
There was a problem hiding this comment.
Yep. Late change here and forgot to update README
https://github.com/NathanDeMaria/PictureToBurn/pull/15/files#diff-2eeaed663bd0d25b7e608891384b7298R12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.