Skip to content

Remove stale PluginPurchaseController and purchase routes#298

Merged
simonhamp merged 1 commit intomainfrom
fix-grandfathering-service
Mar 24, 2026
Merged

Remove stale PluginPurchaseController and purchase routes#298
simonhamp merged 1 commit intomainfrom
fix-grandfathering-service

Conversation

@simonhamp
Copy link
Member

Summary

  • Removes PluginPurchaseController, its 5 routes, and 2 associated views (purchase.blade.php, purchase-success.blade.php)
  • These were dead code reintroduced by a stale merge in PR Refactor plugin checkout to use cart-based approach #261, which was based on a branch predating the tier-based pricing cleanup
  • The controller depended on App\Services\GrandfatheringService, which was intentionally deleted — causing 500 errors on any request to these routes
  • The purchase flow was fully replaced by the cart system; nothing in the app links to these routes

Closes #44

Test plan

  • Verified no views, controllers, or JS reference the removed routes
  • Existing tier-based pricing tests pass (43 tests)
  • Cart-related tests pass (9 tests)
  • Pint passes

🤖 Generated with Claude Code

The PluginPurchaseController and its routes were reintroduced by a stale
merge in PR #261 (cart-based checkout refactor), which was based on a
branch predating the tier-based pricing cleanup. The controller referenced
App\Services\GrandfatheringService which was intentionally deleted, causing
BindingResolutionException errors on any request to purchase routes.

The purchase flow was fully replaced by the cart system — nothing in the
app links to these routes. Remove the dead controller, views, and routes.

Closes #44

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@simonhamp simonhamp marked this pull request as ready for review March 24, 2026 22:54
@simonhamp simonhamp merged commit 664ca1a into main Mar 24, 2026
2 checks passed
@simonhamp simonhamp deleted the fix-grandfathering-service branch March 24, 2026 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant