Modernize Kmeans including TypeScript wrappers#18
Open
Hugo-ter-Doest wants to merge 5 commits intomasterfrom
Open
Modernize Kmeans including TypeScript wrappers#18Hugo-ter-Doest wants to merge 5 commits intomasterfrom
Hugo-ter-Doest wants to merge 5 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a modernized implementation of the KMeans clustering algorithm while preserving backwards compatibility with the original Apparatus API. The legacy implementation has been isolated, and a new, feature-rich
KMeansModernizedclass has been added.The original
kmeans.jsnow acts as a wrapper, delegating to the modern implementation while maintaining the old API for existing consumers.Furthermore, Sylvester is no longer used because direct vector manipulation performs better.
The original implementation is still part of the repo. A benchmark is included that shows the improved performance, both in memory usage and speed.