Refactor: Replace wrapper classes with top-level @Inject composable functions#157
Open
Rolf-Smit wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
+ Coverage 69.79% 70.12% +0.33%
==========================================
Files 144 144
Lines 8140 8101 -39
Branches 1038 1032 -6
==========================================
Hits 5681 5681
+ Misses 1946 1907 -39
Partials 513 513
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Rolf-Smit
force-pushed
the
feature/refactor-dependency-injection-to-metro
branch
from
2cafd19 to
853b49c
Compare
Rolf-Smit
force-pushed
the
feature/refactor-dependency-injection-to-metro-with-top-level-injection
branch
from
144bbf0 to
6914ed9
Compare
Base automatically changed from
feature/refactor-dependency-injection-to-metro
to
main
May 7, 2026 09:36
Rolf-Smit
force-pushed
the
feature/refactor-dependency-injection-to-metro-with-top-level-injection
branch
from
6914ed9 to
5a2669c
Compare
…unctions
The downside of this is that the IDE (Android Studio Quail 1 | 2026.1.1 Canary 1) does not yet resolve the generated class types, and will show "Unresolved reference" on parameters like `PlannerScreen` in `MainNavController`.
A fix can be applied on the IDE (Android Studio) by opening the registry (Ctrl/Cmd+Shift+A, type 'Registry') and disabling the flag `kotlin.k2.only.bundled.compiler.plugins.enabled`. However symbol navigation ('Go to Definition') and similar actions don't seem to work.
Rolf-Smit
force-pushed
the
feature/refactor-dependency-injection-to-metro-with-top-level-injection
branch
from
5a2669c to
03008b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The downside of this is that the IDE (Android Studio Quail 1 | 2026.1.1 Canary 1) does not yet resolve the generated class types, and will show "Unresolved reference" on parameters like
PlannerScreeninMainNavController.A fix can be applied on the IDE (Android Studio) by opening the registry (Ctrl/Cmd+Shift+A, type 'Registry') and disabling the flag
kotlin.k2.only.bundled.compiler.plugins.enabled. However symbol navigation ('Go to Definition') and similar actions don't seem to work.