Skip to content

Cran/description#54

Open
sedv8808 wants to merge 3 commits intodevfrom
cran/description
Open

Cran/description#54
sedv8808 wants to merge 3 commits intodevfrom
cran/description

Conversation

@sedv8808
Copy link
Copy Markdown
Collaborator

Modified Description to match the new CRAN requirements

Modified description file for ORCIDs
Fixed some of the links to point to the right workshop links.
Copilot AI review requested due to automatic review settings April 23, 2026 19:23
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the package’s metadata and documentation to comply with CRAN requirements around internet access (API-backed examples/vignettes) and corrects the Authors@R ORCID formatting per CRAN feedback.

Changes:

  • Updated DESCRIPTION (version/date, Authors@R ORCID format, and expanded Description text).
  • Converted many examples to \dontrun{} and set vignette chunks to not evaluate during checks.
  • Updated ancillary release/CRAN docs (NEWS, cran-comments, codemeta) and some workshop links.

Reviewed changes

Copilot reviewed 51 out of 52 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
vignettes/neotoma2-package.Rmd Adds CRAN internet-access note; disables chunk evaluation globally; updates chunk headers/links.
DESCRIPTION Bumps version/date; changes Authors@R ORCID formatting; adds CRAN-related Description sentences.
NEWS.md Adds 1.0.12 notes and updates prior release notes for CRAN behavior.
cran-comments.md Adds notes about CRAN feedback and summarizes the CRAN-related adjustments.
codemeta.json Updates version and expands description to mention CRAN check behavior.
R/toWide.R Switches roxygen examples to \dontrun{}.
R/taxa.R Switches roxygen examples to \dontrun{}.
R/speleothems.R Switches roxygen examples to \dontrun{}.
R/speleothemdetails.R Switches roxygen examples to \dontrun{}.
R/site-methods.R Switches roxygen examples to \dontrun{} for [[, doi, cite_data.
R/set_server.R Switches roxygen examples to \dontrun{}.
R/samples.R Switches roxygen examples to \dontrun{}.
R/plotLeaflet.R Switches roxygen examples to \dontrun{}.
R/pingNeotoma.r Switches roxygen examples to \dontrun{}.
R/getids.r Switches roxygen examples to \dontrun{}.
R/get_table.R Switches roxygen examples to \dontrun{}.
R/get_stats.R Switches roxygen examples to \dontrun{}.
R/get_speleothems.R Switches roxygen examples to \dontrun{}.
R/get_sites.R Switches roxygen examples to \dontrun{} and simplifies example content.
R/get_publications.R Switches roxygen examples to \dontrun{}.
R/get_manual.R Switches roxygen examples to \dontrun{}.
R/get_downloads.R Switches roxygen examples to \dontrun{}.
R/get_documentation.R Switches roxygen examples to \dontrun{}.
R/get_datasets.R Switches roxygen examples to \dontrun{}.
R/filter.R Switches roxygen examples to \dontrun{}.
R/clean.R Switches roxygen examples to \dontrun{}.
R/01_classDefinitions.R Wraps class example in braces.
man/toWide.Rd Converts example to \dontrun{} and removes tryCatch wrapper.
man/taxa-sites-method.Rd Converts example to \dontrun{} and removes tryCatch wrapper.
man/sub-sub.Rd Converts example to \dontrun{} and removes tryCatch wrapper.
man/speleothems-sites-method.Rd Converts example to \dontrun{} and removes tryCatch wrapper.
man/speleothemdetails-sites-method.Rd Converts example to \dontrun{} and removes tryCatch wrapper.
man/set_server.Rd Converts example to \dontrun{}.
man/samples-sites-method.Rd Converts example to \dontrun{} and removes tryCatch wrapper.
man/plotLeaflet-sites-method.Rd Converts example to \dontrun{} (keeps tryCatch).
man/pingNeotoma.Rd Converts example to \dontrun{}.
man/getids.Rd Converts example to \dontrun{} and removes tryCatch wrapper.
man/get_table.Rd Converts example to \dontrun{} and removes tryCatch wrapper.
man/get_stats.Rd Converts example to \dontrun{}.
man/get_speleothems.Rd Converts example to \dontrun{} and removes tryCatch wrapper.
man/get_sites.Rd Converts example to \dontrun{} and simplifies example content.
man/get_publications.Rd Converts example to \dontrun{}.
man/get_manual.Rd Converts example to \dontrun{}.
man/get_downloads.Rd Converts example to \dontrun{}.
man/get_documentation.Rd Converts example to \dontrun{}.
man/get_datasets.Rd Converts example to \dontrun{}.
man/filter.Rd Converts example to \dontrun{}.
man/doi-sites-method.Rd Converts example to \dontrun{} and removes tryCatch wrapper.
man/contacts_classes.Rd Wraps class example in braces.
man/clean.Rd Converts example to \dontrun{}.
man/cite_data-sites-method.Rd Converts example to \dontrun{} but no longer calls cite_data().
Comments suppressed due to low confidence (1)

vignettes/neotoma2-package.Rmd:32

  • The setup_md chunk defines safe_eval, but it won’t run because chunk evaluation is globally disabled immediately before this (and the function is not used elsewhere in the vignette). Either remove this helper or explicitly set this chunk to eval=TRUE and use it for inline fallbacks, to avoid dead/unreachable setup code.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +17 to 25
> **Note**
> This package is an interface to an external web API.
> To comply with CRAN policies on Internet access, code examples in this vignette
> are shown but not executed during CRAN checks.
> Users can run all examples locally after installation.

```{r setOpts, include = FALSE}
knitr::opts_chunk$set(
collapse = TRUE,
comment = "#>"
)
api_available <- FALSE
res <- pingNeotoma()
if (res$status_code == 200) {
api_available <- TRUE
}
# Disable evaluation globally if API is down
knitr::opts_chunk$set(eval = FALSE,
error = TRUE)
Copy link

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

knitr::opts_chunk$set(eval = FALSE) disables evaluation for all vignette builds, not just CRAN checks. This contradicts the note that examples are only not executed during CRAN checks. Consider gating eval on an environment signal (e.g., Sys.getenv("NOT_CRAN") / isTRUE(getOption("pkg.build_vignettes"))) so local vignette builds can still run while CRAN remains non-executing.

Copilot uses AI. Check for mistakes.
Comment thread R/site-methods.R
#' tryCatch({
#' @examples \dontrun{
#' # Get datasets metadata from API
#' ds <- get_datasets(1)
Copy link

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cite_data roxygen example no longer demonstrates the function being documented (it only assigns ds <- get_datasets(1) and then stops). Add a call to cite_data(ds) (or an equivalent minimal usage) so the generated Rd example remains meaningful, even when wrapped in \dontrun{}.

Suggested change
#' ds <- get_datasets(1)
#' ds <- get_datasets(1)
#' cite_data(ds)

Copilot uses AI. Check for mistakes.
Comment thread DESCRIPTION
Comment on lines 18 to +21
Description: Access and manipulation of data using the Neotoma Paleoecology Database.
<https://api.neotomadb.org/api-docs/>.
Examples in functions that require API access are not executed during CRAN checks.
Vignettes do not execute as to avoid API calls during CRAN checks.
Copy link

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added DESCRIPTION text focuses on CRAN-check behavior (and includes multiple long lines). CRAN may flag non-functional/administrative content in the package Description and/or lines >80 characters. Consider keeping Description focused on what the package does, moving CRAN-check specifics to cran-comments/README, and reflowing Description lines to stay within recommended width.

Suggested change
Description: Access and manipulation of data using the Neotoma Paleoecology Database.
<https://api.neotomadb.org/api-docs/>.
Examples in functions that require API access are not executed during CRAN checks.
Vignettes do not execute as to avoid API calls during CRAN checks.
Description: Access and manipulate data from the Neotoma Paleoecology
Database. See <https://api.neotomadb.org/api-docs/>.

Copilot uses AI. Check for mistakes.
Comment thread DESCRIPTION
Comment on lines 6 to 7
c(person(given = "Dominguez Vidana",
family = "Socorro",
Copy link

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Authors@R, the first author’s given/family names appear swapped (given = "Dominguez Vidana", family = "Socorro"). Other project metadata (e.g., CITATION.cff) lists given-names: Socorro and family-names: Dominguez Vidana, so DESCRIPTION likely should match to ensure correct author display on CRAN.

Suggested change
c(person(given = "Dominguez Vidana",
family = "Socorro",
c(person(given = "Socorro",
family = "Dominguez Vidana",

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants