Skip to content

Support Direct Data Protection Volume Provisioning #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
goog-drewk wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Support Direct Data Protection Volume Provisioning #875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/csi/controller_helpers/kubernetes/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ const (
AnnVolumeShareFromPVC = annPrefix + "/shareFromPVC"
AnnVolumeShareToNS = annPrefix + "/shareToNamespace"
AnnReadOnlyClone = annPrefix + "/readOnlyClone"
AnnIsMirrorDestination = annPrefix + "/isMirrorDestination"
)

var features = map[controllerhelpers.Feature]*versionutils.Version{
Expand Down
7 changes: 7 additions & 0 deletions frontend/csi/controller_helpers/kubernetes/helper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,12 @@ func getVolumeConfig(
Logc(ctx).WithError(err).Warning("Unable to parse notManaged annotation into bool.")
}

isMirrorDestination, err := strconv.ParseBool(getAnnotation(annotations, AnnIsMirrorDestination))
if err != nil {
Logc(ctx).WithError(err).Warning("Unable to parse isMirrorDestination annotation into bool.")
isMirrorDestination = false
}

return &storage.VolumeConfig{
Name: name,
Size: fmt.Sprintf("%d", size.Value()),
Expand All @@ -609,6 +615,7 @@ func getVolumeConfig(
MountOptions: strings.Join(storageClass.MountOptions, ","),
RequisiteTopologies: requisiteTopology,
PreferredTopologies: preferredTopology,
IsMirrorDestination: isMirrorDestination,
}
}

Expand Down