Skip to content

Resave models with newlines around code and info section#449

Open
kgmt0 wants to merge 1 commit intoNetLogo:java21from
kgmt0:code-info-newlines
Open

Resave models with newlines around code and info section#449
kgmt0 wants to merge 1 commit intoNetLogo:java21from
kgmt0:code-info-newlines

Conversation

@kgmt0
Copy link
Copy Markdown
Contributor

@kgmt0 kgmt0 commented Apr 30, 2026

@kgmt0
Copy link
Copy Markdown
Contributor Author

kgmt0 commented Apr 30, 2026

Some tests are failing, but they seem to be consistent with current failures in the java21 branch.

@kgmt0 kgmt0 requested review from TheBizzle and removed request for TheBizzle April 30, 2026 02:57
@kgmt0 kgmt0 marked this pull request as draft April 30, 2026 03:52
@kgmt0 kgmt0 force-pushed the code-info-newlines branch from 4a2cf75 to c069855 Compare April 30, 2026 21:14
@kgmt0 kgmt0 marked this pull request as ready for review April 30, 2026 21:53
@kgmt0 kgmt0 requested a review from TheBizzle April 30, 2026 21:53
@TheBizzle TheBizzle self-requested a review May 1, 2026 21:09
@TheBizzle
Copy link
Copy Markdown
Member

@kgmt0 , it doesn't look to me like it's wholly consistent with the other test failures.

Yours fails with:

[info] *** 6 TESTS FAILED ***
[error] Failed tests:
[error] 	org.nlogo.models.ButtonTests
[error] 	org.nlogo.models.InfoTabsTests
[error] 	org.nlogo.models.LegalInformationTests
[error] 	org.nlogo.models.ModelCompilationTests
[error] 	org.nlogo.models.VersionTests

The previous state of the branch was failing with:

[info] *** 3 TESTS FAILED ***
[error] Failed tests:
[error] 	org.nlogo.models.ButtonTests
[error] 	org.nlogo.models.LegalInformationTests
[error] 	org.nlogo.models.VersionTests

I think your changes introduced new errors.

@kgmt0
Copy link
Copy Markdown
Contributor Author

kgmt0 commented May 1, 2026

Oh, that comment is outdated. The errors were consistent before I bumped the NetLogo version in the models, but now there are new errors.

@kgmt0
Copy link
Copy Markdown
Contributor Author

kgmt0 commented May 1, 2026

@TheBizzle The new errors seem to just be about unknown version number, which is expected since I bumped the version number, and the test cases in this repo are not using NetLogo with my PR applied. Should I try to adjust the tests to use NetLogo from the wip-7.1 branch, or is it okay to just merge it like this?

@TheBizzle
Copy link
Copy Markdown
Member

My preferred fix here is:

  • Get wip-7.1 passing tests for NetLogo
  • We publish an artifact for the tests-passing version of wip-7.1
  • Make this branch depend on that artifact

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants