Open
Conversation
drewnoakes
reviewed
Sep 6, 2021
Member
drewnoakes
left a comment
drewnoakes
left a comment
There was a problem hiding this comment.
As someone who works on the Visual Studio project system, I love to see this kind of migration. Thanks!
A few comments here for things to fix up before we can merge this.
...liability (Freelance Pattern)/Model One/Freelance.ModelOne.Client/Properties/AssemblyInfo.cs
Show resolved
Hide resolved
src/Majordomo/MDPClientAsyncExample/MDPClientAsyncExample.csproj
Outdated
Show resolved
Hide resolved
- added Build props file for solution - fixed framework supported versions - remove duplicated netcoreapp3.1
fixup original copyright information from assemblyinfo
- samples Client. both Server and Server2 versions
Author
|
@drewnoakes i think it's for review now, but i'm didn't port two last samples Multitheading and LazyPirate.Client2 those two still broked:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.