Delete override on templated methods #35
Open
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
cc @rostyboost @CyberShadow . |
Contributor
|
LGTM but I do not have merge rights here. Was there a deprecation cycle for this? |
|
The dmd PR currently makes it an error, but I'll change it to a deprecation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template methods cannot be virtual because they can essentially populate the vtable infinitely. Override is accepted on templates, but it is ignored. A PR to dmd has been raised to make it an error [1] so that the user does not have false assumptions; that PR is currently blocked and will be unblocked by this PR.
[1] dlang/dmd#15350