Skip to content

Optionally save model before ensure model fit#870

Merged
bruAristimunha merged 5 commits intoNeuroTechX:developfrom
davisethan:ensure-fitted-bug
Jan 19, 2026
Merged

Optionally save model before ensure model fit#870
bruAristimunha merged 5 commits intoNeuroTechX:developfrom
davisethan:ensure-fitted-bug

Conversation

@davisethan
Copy link
Copy Markdown
Contributor

@davisethan
Copy link
Copy Markdown
Contributor Author

The helper function _ensure_fitted was added in this PR #852.

@davisethan
Copy link
Copy Markdown
Contributor Author

davisethan commented Jan 15, 2026

I'm not sure if I updated the what's new file correctly, please let me know if there's changes I should make. Additionally, I'm not sure if this patch is the best case scenario. But, it safely pickles models (_save_model_cv) before updating in-place (_ensure_fitted) for scoring. I made this patch because it is blocking my workflow, which involves pickling and un-pickling models to get more than one score; e.g. AUROC, NLL, ECE.

@davisethan davisethan mentioned this pull request Jan 15, 2026
@bruAristimunha bruAristimunha enabled auto-merge (squash) January 18, 2026 23:50
@bruAristimunha bruAristimunha merged commit c362bd2 into NeuroTechX:develop Jan 19, 2026
14 of 15 checks passed
@davisethan davisethan deleted the ensure-fitted-bug branch January 19, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants