Add fly_overlap, fly_select modes, and document footprint assumptions#11
Merged
NewGraphEnvironment merged 1 commit intomainfrom Mar 5, 2026
Merged
Conversation
…#8) - fly_select() gains mode param: "minimal" (fewest photos, default) and "all" (every photo touching AOI) - New fly_overlap() reports pairwise overlap % between photo footprints - Document 9x9 negative assumption and flat-terrain limitation in fly_footprint(), fly_overlap(), and vignette - Guard st_area() against empty geometry from full coverage - Simplify vignette with both modes, overlap analysis, and multi-scale workflow that sorts scales finest-first - 64 tests all passing, 0 errors 0 warnings on R CMD check Closes #8 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fly_select()gainsmodeparam:"minimal"(fewest photos) and"all"(every photo touching AOI)fly_overlap()for pairwise overlap stats between photo footprintsCloses #8
Relates to NewGraphEnvironment/sred-2025-2026#17
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com