Skip to content

Add fly_fetch and URL columns to test data#17

Merged
NewGraphEnvironment merged 1 commit intomainfrom
issue-15-url-columns-download
Mar 11, 2026
Merged

Add fly_fetch and URL columns to test data#17
NewGraphEnvironment merged 1 commit intomainfrom
issue-15-url-columns-download

Conversation

@NewGraphEnvironment
Copy link
Owner

Summary

  • Add fly_fetch() — downloads thumbnails, flight logs, calibration reports, or georef files from BC Data Catalogue URLs
  • Include URL columns (thumbnail_image_url, flight_log_url, camera_calibration_url, patb_georef_url) and flight metadata (focal_length, flying_height, ground_sample_distance) in bundled test data
  • Update data-raw/make_testdata.R to retain these columns and reference diggs (renamed from airbc)
  • 7 new tests for fly_fetch()

Fixes #15
Relates to NewGraphEnvironment/sred-2025-2026#17

Test plan

  • devtools::test() — 85 tests pass
  • All 20 test photos have valid thumbnail URLs (confirmed download 20/20)
  • fly_fetch() handles NA URLs, missing columns, invalid type, overwrite skip

🤖 Generated with Claude Code

Include thumbnail_image_url, flight_log_url, camera_calibration_url,
patb_georef_url, focal_length, flying_height, and ground_sample_distance
in bundled test data. Add fly_fetch() to download files by type.

Fixes #15

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@NewGraphEnvironment NewGraphEnvironment merged commit bfca83b into main Mar 11, 2026
1 check passed
@NewGraphEnvironment NewGraphEnvironment deleted the issue-15-url-columns-download branch March 11, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add URL columns and fly_download for thumbnail/flight log retrieval

1 participant