Merged
Conversation
- Add send_log() and send_notify() for scheduled send outcomes (#2) - Replace hardcoded email default with getOption/env var pattern (#3) - Error on non-existent .md file paths in mc_compose (#4) - Extract shared strip_md_header() helper (#5) - Add mocked unit tests for MIME building, send_log, default_from (#6) - Update README with setup section and send log docs - Update vignette with send log notification docs Closes #2 Closes #3 Closes #4 Closes #5 Closes #6 Relates to NewGraphEnvironment/sred-2025-2026#4 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.mc/send_log.txtand fire macOS desktop notifications on success, skip, or failuregetOption("mc.from")/MC_FROMenv var replaces hardcoded email defaultmc_compose()now errors on non-existent.mdpaths instead of silently treating them as HTMLstrip_md_header()used by bothmc_md_render()andmc_compose()Closes #2
Closes #3
Closes #4
Closes #5
Closes #6
Relates to NewGraphEnvironment/sred-2025-2026#4
Test plan
devtools::test()— 125 passinglintr::lint_package()— 0 lintsmc_send(html = ..., send_at = 1, test = TRUE)— check~/.mc/send_log.txtand desktop notificationoptions(mc.from = ...)picks up in fresh R session🤖 Generated with Claude Code