feat: Improve IconButton accessibility and ARIA labels#22746
Open
paulGeoghegan wants to merge 1 commit into
Open
feat: Improve IconButton accessibility and ARIA labels#22746paulGeoghegan wants to merge 1 commit into
paulGeoghegan wants to merge 1 commit into
Conversation
Member
|
I will forward this internally so it doesn't get lost Next Monday. |
Author
|
Thank you!
…On Fri 24 Apr 2026, 22:56 Sewer., ***@***.***> wrote:
*Sewer56* left a comment (Nexus-Mods/Vortex#22746)
<#22746 (comment)>
I will forward this internally so it doesn't get lost.
—
Reply to this email directly, view it on GitHub
<#22746 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANRVYRPECUHFERIYN7IZLW34XPPHJAVCNFSM6AAAAACYFWXU62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DGMJWGY2DQOBRGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
|
The PR has a lot of unrelated changes that undo previous work. I recommend rebasing on current master and only committing related changes. |
|
This PR doesn't have conflicts anymore. It can be merged after all status checks have passed and it has been reviewed. |
Author
|
I can undo them, it wdy't build without them though.
…On Sat 25 Apr 2026, 11:24 github-actions[bot], ***@***.***> wrote:
*github-actions[bot]* left a comment (Nexus-Mods/Vortex#22746)
<#22746 (comment)>
This PR doesn't have conflicts anymore. It can be merged after all status
checks have passed and it has been reviewed.
—
Reply to this email directly, view it on GitHub
<#22746 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANRVYRMJRLBY24T25KXAE734XSG5PAVCNFSM6AAAAACYFWXU62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DGMJYHE2DKMZZGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Require and surface accessible names for header buttons and badges. IconButton now accepts a mandatory aria-label, appends item count into the accessible name, and marks the visual count badge aria-hidden. Added aria-labels to Help and Notifications popover buttons, and added aria-expanded/aria-label to the menu toggle in Header.
Author
|
@erri120 let me know if this is okay now. I can't build anymore but hopefully the changes are okay. |
|
This PR has been marked as stale due to inactivity. |
Author
|
Hi there, just trying to stop it from going stale.
…On Sun 3 May 2026, 11:29 github-actions[bot], ***@***.***> wrote:
*github-actions[bot]* left a comment (Nexus-Mods/Vortex#22746)
<#22746 (comment)>
This PR has been marked as stale due to inactivity.
—
Reply to this email directly, view it on GitHub
<#22746 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANRVYRJ5H5OG3FZUGLFUGTL4Y4NPFAVCNFSM6AAAAACYFWXU62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DGNRVHE2TCNZQHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
This PR has conflicts. You need to rebase the PR before it can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #22739
Require and propagate accessible names for IconButton and add ARIA attributes across header components. IconButton now accepts an "aria-label" prop, composes a final aria-label that includes the item count (if present), and hides the visual count badge from screen readers (aria-hidden). Updated appearanceMap typing/formatting and component return to use the composed aria-label. Also added aria-label/aria-expanded attributes to Help, Notifications and menu toggle buttons and made minor JSX/import formatting tweaks to improve clarity and accessibility.