Conversation
Allowing to build against a system installed copy.
That's what the README suggests and - more importantly - the cmake config file works with. Also use angle brackets instead of quotation marks in two cases.
Makes the life of packagers and everybody who wants to build this easier. Closes #25.
This hopefully fixes the issue related to reading a file that travis doesn't have read access to causing docker build to fail
Member
Author
|
I realize that CI is still not working correctly, but having built this manually and confirming that it works as expected, I'm merging it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Essentially a duplicate of mujx/mtxclient#28
Thanks @heirecka