Show rename buttons as disabled if unusable; allow typewriter while song plays#208
Merged
asiekierka merged 1 commit intoNitrousTracker:newfrom Mar 8, 2026
Merged
Conversation
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly shows the "ren" buttons for instrument and sample as disabled if pressing them wouldn't do anything (in the case of a null sample or instrument).
Also, allows typewriters to appear whilst the song is playing, without having them be overlapped by
lbpot, by redrawing the typewriter (if it exists) after every pattern change, i.e. afterlbpotis redrawn, instead of just silently blocking the dialogue from appearing.