Skip to content

python3Packages.llm-cmd: init at 0.2a0#359379

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
Erethon:init-llm-cmd
Jan 8, 2025
Merged

python3Packages.llm-cmd: init at 0.2a0#359379
GaetanLepage merged 1 commit intoNixOS:masterfrom
Erethon:init-llm-cmd

Conversation

@Erethon
Copy link
Copy Markdown
Contributor

@Erethon Erethon commented Nov 26, 2024

This is a plugin for the already packaged llm software. Homepage of the project.

#268955, #327800, #344746 are PRs that add similar plugins.

Output of running llm plugins after building this package:

llm plugins                         
[                                                                   
  {                                                                 
    "name": "llm-cmd",                                              
    "hooks": [
      "register_commands"                                           
    ],                                                              
    "version": "0.2a0"                                      
  }                                                
]  

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg Bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 27, 2024
Comment thread pkgs/by-name/ll/llm-cmd/package.nix Outdated
Comment thread pkgs/by-name/ll/llm-cmd/package.nix Outdated
Comment thread pkgs/by-name/ll/llm-cmd/package.nix Outdated
Comment thread pkgs/by-name/ll/llm-cmd/package.nix Outdated
@Erethon
Copy link
Copy Markdown
Contributor Author

Erethon commented Jan 8, 2025

Thank you for the review @GaetanLepage, I've resolved all the issues you've mentioned. I've also added a patch that I upstreamed to fix a failing test when using a recent llm version. I don't know if we prefer having a patch for the test or disabling the test, so let me know if we prefer disabling the test instead.

@GaetanLepage
Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 359379


x86_64-linux

✅ 2 packages built:
  • llm-cmd
  • llm-cmd.dist

aarch64-linux

✅ 2 packages built:
  • llm-cmd
  • llm-cmd.dist

x86_64-darwin

✅ 2 packages built:
  • llm-cmd
  • llm-cmd.dist

aarch64-darwin

✅ 2 packages built:
  • llm-cmd
  • llm-cmd.dist

@github-actions github-actions Bot removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 8, 2025
@Erethon Erethon mentioned this pull request Jan 8, 2025
13 tasks
@github-actions github-actions Bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 8, 2025
@nix-owners nix-owners Bot requested a review from natsukium January 8, 2025 16:31
@Erethon
Copy link
Copy Markdown
Contributor Author

Erethon commented Jan 8, 2025

Updated PR to use buildPythonPackage instead of buildPythonApplication as per the discussion in #344746 and #372171

@GaetanLepage
Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 359379


x86_64-linux

✅ 4 packages built:
  • python312Packages.llm-cmd
  • python312Packages.llm-cmd.dist
  • python313Packages.llm-cmd
  • python313Packages.llm-cmd.dist

aarch64-linux

✅ 4 packages built:
  • python312Packages.llm-cmd
  • python312Packages.llm-cmd.dist
  • python313Packages.llm-cmd
  • python313Packages.llm-cmd.dist

x86_64-darwin

✅ 4 packages built:
  • python312Packages.llm-cmd
  • python312Packages.llm-cmd.dist
  • python313Packages.llm-cmd
  • python313Packages.llm-cmd.dist

aarch64-darwin

✅ 4 packages built:
  • python312Packages.llm-cmd
  • python312Packages.llm-cmd.dist
  • python313Packages.llm-cmd
  • python313Packages.llm-cmd.dist

Copy link
Copy Markdown
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@GaetanLepage GaetanLepage merged commit f9aff72 into NixOS:master Jan 8, 2025
aos added a commit to aos/nixpkgs that referenced this pull request Jan 11, 2025
This is a plugin for the already packaged `llm` software. There already
exists a PR for this here: NixOS#327800
but it has not gone anywhere after multiple months. I've decided to fork
and update it to the latest.

We also have other PRs that have been commited that add similr plugins at NixOS#359379 and NixOS#344746.
aos added a commit to aos/nixpkgs that referenced this pull request Feb 15, 2025
Closes NixOS#327800
Closes NixOS#372713

(Note: This is just NixOS#373495 upgraded to `0.12`. Seems like something
happened with git/Github and my PR was automatically closed.)

This is a plugin for the already packaged `llm` software. There exists 2 PRs related to this:
- NixOS#327800: the original
- NixOS#372713: forks the original and updates as it had no activity for multiple months

As helpfully pointed out by @ShaddyDC (NixOS#372713 (comment)) this is now superseded by `llm-anthropic`, of which this is meant to package.

(We also have other PRs that have been commited that add similr plugins at NixOS#359379 and NixOS#344746.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants