Skip to content

Standardize rule endpoint client identification#643

Open
TheJeffreyKuo wants to merge 1 commit intodevelopfrom
561-standardize-rule-endpoint-client-identification-and-remove-basic-auth
Open

Standardize rule endpoint client identification#643
TheJeffreyKuo wants to merge 1 commit intodevelopfrom
561-standardize-rule-endpoint-client-identification-and-remove-basic-auth

Conversation

@TheJeffreyKuo
Copy link
Copy Markdown

Changes

Standardized client identification across all rule endpoints by moving client_id into the URL path. Previously add_rule and delete_rule pulled it from a Basic Auth header while subscribe_rules and unsubscribe_rules pulled it from the JSON body. Instead, all rule endpoint reads client_id now. The frontend API layer was updated to match this.

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No package-lock.json changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #561

@TheJeffreyKuo TheJeffreyKuo requested a review from bracyw May 3, 2026 23:32
@TheJeffreyKuo TheJeffreyKuo self-assigned this May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standardize rule endpoint client identification and remove Basic Auth

1 participant