Conversation
leanish
reviewed
Mar 14, 2025
|
|
||
| // to publish to local maven repo skip signing: ./gradlew publishToMavenLocal -x signGraphqlJavaPublication | ||
| signing { | ||
| required = { !version.endsWith("nosto") } |
There was a problem hiding this comment.
interesting
I don't see references to this here, but I guess it's read from signing anyways?
Author
There was a problem hiding this comment.
It's coming from the signing-plugin and activates when publishing. I disabled it now for our own release version as it requires key setup for signing.
leanish
reviewed
Mar 14, 2025
Comment on lines
+166
to
+167
| tasks.register('publishToNostoRepo') { | ||
| dependsOn 'publishMavenPublicationToMavenRepository' |
Author
There was a problem hiding this comment.
yes because with the normal publish-task it would try to upload to the sonatype repo that upstream also uses.
leanish
reviewed
Mar 14, 2025
Comment on lines
+28
to
+33
| compileJava { | ||
| options.release = 11 | ||
| } | ||
| compileTestJava { | ||
| options.release = 11 | ||
| } |
There was a problem hiding this comment.
could you add a comment expressing we want to keep it as v11 so the changes we apply can be also applied to the original project?
leanish
approved these changes
Mar 14, 2025
leanish
left a comment
leanish
left a comment
There was a problem hiding this comment.
added some minor comment but LGTM otherwise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.