-
Notifications
You must be signed in to change notification settings - Fork 309
Implement automatic micro batch sizing #1060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jonahsamost
wants to merge
9
commits into
NovaSky-AI:main
Choose a base branch
from
jonahsamost:jonah_2_9_batchsize
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9278d16
initial train tests pass
jonahsamost 0a73d01
working train
jonahsamost dfdb247
reformat
jonahsamost e3feb82
formatting
jonahsamost 7fc0d53
add tx
jonahsamost 544bc1f
bot issues
jonahsamost a69411d
bot review
jonahsamost 94a954a
bot review
jonahsamost b2b4a1d
bot review
jonahsamost File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The automatic micro-batch sizing implementation has a critical flaw: it only profiles the policy model and completely ignores the critic model. This can lead to Out-Of-Memory (OOM) errors during critic training if the critic model is more memory-intensive than the policy model.
Additionally, there's an inconsistency in how the determined budget is used:
_token_budgetwithMemoryAwareBatchIteratorfor dynamic batching based on sequence length, which is efficient._token_budgetis never set for them. They fall back to using a fixedmicro_train_batch_size_per_gpucalculated in this function from the policy's budget. This is inconsistent and misses the benefits of dynamic packing.To fix this, the function should be updated to:
MemoryAwareBatchIteratorfor efficient, memory-safe training.micro_bsand setting it on the config should be removed, as it's inconsistent with the token budget approach.This will require adding
auto_determine_token_budgettoCriticWorkerBaseand a method (e.g.,_set_token_budget) to all workers to apply the final global budget.