[tinker] Propagate all uv run args from server startup command to backend workers#1255
Open
[tinker] Propagate all uv run args from server startup command to backend workers#1255
uv run args from server startup command to backend workers#1255Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the logic for propagating uv run arguments from the API server to the backend workers, replacing the specific _get_parent_uv_accelerator_extras function with a more general _get_parent_uv_run_args and encapsulating command building in _build_uv_run_cmd_engine. While these changes improve modularity and robustness, a security risk has been identified: the implementation logs these uv run arguments and includes them in exception messages. As uv run arguments can contain sensitive information (e.g., secrets passed via --env), this could lead to sensitive data exposure in application logs. It is recommended to sanitize these logs to prevent such exposure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1234
After the fixes in this PR, I can successfully train with
meta-llama/Llama-3.2-1Bby passing an env-file to the server startup command :(For context: See #1231 )