Skip to content

[tinker] Propagate all uv run args from server startup command to backend workers#1255

Open
SumanthRH wants to merge 4 commits intomainfrom
sumanthrh/propagate-uv-args
Open

[tinker] Propagate all uv run args from server startup command to backend workers#1255
SumanthRH wants to merge 4 commits intomainfrom
sumanthrh/propagate-uv-args

Conversation

@SumanthRH
Copy link
Member

@SumanthRH SumanthRH commented Mar 3, 2026

What does this PR do?

Fixes #1234

After the fixes in this PR, I can successfully train with meta-llama/Llama-3.2-1B by passing an env-file to the server startup command :

 uv run --extra tinker --extra fsdp --env-file skyrl-train/.env.example -m skyrl.tinker.api  --base-mod
el meta-llama/Llama-3.2-1B   --backend fsdp 

(For context: See #1231 )


Open with Devin

x
Signed-off-by: SumanthRH <sumanthrh99@gmail.com>
x
Signed-off-by: SumanthRH <sumanthrh99@gmail.com>
x
Signed-off-by: SumanthRH <sumanthrh99@gmail.com>
x
Signed-off-by: SumanthRH <sumanthrh99@gmail.com>
@SumanthRH SumanthRH marked this pull request as ready for review March 3, 2026 05:19
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the logic for propagating uv run arguments from the API server to the backend workers, replacing the specific _get_parent_uv_accelerator_extras function with a more general _get_parent_uv_run_args and encapsulating command building in _build_uv_run_cmd_engine. While these changes improve modularity and robustness, a security risk has been identified: the implementation logs these uv run arguments and includes them in exception messages. As uv run arguments can contain sensitive information (e.g., secrets passed via --env), this could lead to sensitive data exposure in application logs. It is recommended to sanitize these logs to prevent such exposure.

@SumanthRH SumanthRH requested a review from pcmoritz March 3, 2026 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[train] uv environment variables not propagated to the backend with tinker API server

1 participant