[train] Add importance weight diagnostics and fix IS loss overflow#1261
Draft
tyler-griggs wants to merge 2 commits intomainfrom
Draft
[train] Add importance weight diagnostics and fix IS loss overflow#1261tyler-griggs wants to merge 2 commits intomainfrom
tyler-griggs wants to merge 2 commits intomainfrom
Conversation
- Add compute_iw_metrics() for monitoring IW health (ratio mean/std/max/min) - Integrate IW metrics into CISPO and importance_sampling losses - Fix importance_sampling_loss: use safe_exp_delta (was only loss using raw torch.exp, risking inf * 0 = nan in off-policy scenarios) - Make importance_sampling_loss use reduce_loss and apply_off_policy_correction (matching the pattern of all other loss functions) - Add CISPO to repopulate_registry Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Tests verify correct loss computation, IW diagnostic metrics, and numerical safety (safe_exp_delta prevents overflow for extreme ratios). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compute_iw_metrics(): logs ratio mean/std/max/min for CISPO and IS lossesimportance_sampling_loss: usesafe_exp_delta(was only loss using rawtorch.exp)importance_sampling_lossnow usesreduce_lossandapply_off_policy_correctionrepopulate_registryTest plan
🤖 Generated with Claude Code