resolves #103 by updating config, eas and cphotang#104
Merged
jfkrizmanic merged 14 commits intomainfrom Mar 24, 2025
Merged
Conversation
Areustle
requested review from
TobiasHeibges and
jfkrizmanic
and removed request for
TobiasHeibges
- Set 'Greisen' as the default value for the cherenkov_light_engine field in the Simulation class. - Added validation to replace 'Default' with 'Greisen' when parsing input configurations.
- Adjusted existing tests to reflect that 'Greisen' is now the default value for the cherenkov_light_engine field.
- Added new tests to verify that 'Default' is replaced by 'Greisen' during simulation configuration.
- Included validation tests to ensure that only valid values ('Greisen', 'Gaisser-Hillas') are accepted for the cherenkov_light_engine field, and that invalid values raise appropriate errors.
Contributor
Author
…top height - Updated the condition in the CphotAng class to ensure early return checks for segments above the cloud-top height handle cases where the segment list has fewer than 2 elements. - This change prevents potential index errors by checking the length of the segment list before accessing elements.
Contributor
Author
|
@jfkrizmanic Please approve of the merge! |
jfkrizmanic
reviewed
Mar 24, 2025
| # From https://pdg.lbl.gov/2024/AtomicNuclearProperties/HTML/air_dry_1_atm.html | ||
| X0 = 61.3 | ||
| Xm = 739.0 | ||
| gh_lam = 65.12 |
Contributor
There was a problem hiding this comment.
please add a comment line above this: "# 65.17 g/cm^2 value obtained by evaluating lambda at Xmax for 1000 upward pion 10^17 eV EAS at 5 deg Earth-emergence angle and starting at sea level"
jfkrizmanic
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#103