[18.0][FIX] contract_refund_on_stop - fix exception when recurring_next_date is empty#1394
Open
anthonissen-a wants to merge 1 commit into
Open
Conversation
Contributor
|
Hi @sbejaoui, |
Contributor
|
Hi @anthonissen-a , tests are failing. |
Contributor
|
Hi see that the fix is already in #1396 sorry. |
Contributor
|
@anthonissen-a can you rebase? |
anthonissen-a
force-pushed
the
18.0-contract_refund_on_stop_fix_markers-aan
branch
from
7fa6985 to
e7f9784
Compare
OCA-git-bot
added
series:18.0
mod:contract_refund_on_stop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a contract line is completely invoiced, it has no more value in its field
recurring_next_date. In this case, it's impossible to stop the contract line due to an RPC_ERROR in_insert_markers().