[19.0][IMP] edi_core_oca: gracefully handle EDINotImplementedError to prevent batch failures on crons#273
Open
HviorForgeFlow wants to merge 1 commit into
Conversation
Contributor
OCA-git-bot
added
mod:edi_core_oca
Contributor
|
Wondering: why is it possible to handle an exc type w/o handler? It should be validated beforehand... We should make specific validators required based on the direction. |
HviorForgeFlow
force-pushed
the
19.0-imp-edi_core_oca-skip-not-edi-implement-on-crons
branch
from
11c86d7 to
960d553
Compare
HviorForgeFlow
force-pushed
the
19.0-imp-edi_core_oca-skip-not-edi-implement-on-crons
branch
from
960d553 to
8d1870f
Compare
HviorForgeFlow
force-pushed
the
19.0-imp-edi_core_oca-skip-not-edi-implement-on-crons
branch
from
8d1870f to
c20e67c
Compare
OCA-git-bot
removed
mod:edi_purchase_oca
Member
Author
That makes more sense, cleaner implementation, thanks for the advice |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed while developing that when a exchange type is not linked to a handler and the EDINotImplementedError is raised, a DB rollback takes places undoing all previous work.
To ensure that skipping not handled exchanges does not break anything outside the cron scope I had to slightly change the exchange_generate_send method.
CC @etobella @simahawk @ForgeFlow