[17.0][ADD] report_printed_flag#1161
Draft
atgalvez08 wants to merge 1 commit intoOCA:17.0from
Draft
Conversation
…ramework This module provides a reusable framework to track printed QWeb PDF reports across business models. It introduces: - printed configuration models - printed logs - reusable printed mixin - report integration hooks Features: - configurable printed tracking per model and report - optional printed logs - optional printed report names - multi-company support - reusable mixin for extension modules The implementation is designed to be extended by satellite modules such as account and stock integrations.
atgalvez08
force-pushed
the
17.0-add-report_printed_flag
branch
from
d42bbb5 to
3b6049d
Compare
rrebollo
suggested changes
May 7, 2026
Contributor
rrebollo
left a comment
rrebollo
left a comment
There was a problem hiding this comment.
Please consider my suggestions. I think you'll find some of them compelling.
| # Load configurations for model and companies involved | ||
| configs = self.env["report.printed.config"].search( | ||
| [ | ||
| ("active", "=", True), |
Contributor
There was a problem hiding this comment.
Suggested change
| ("active", "=", True), |
| [ | ||
| ("active", "=", True), | ||
| ("model", "=", model_name), | ||
| ("company_id", "in", records.mapped("company_id").ids), |
Contributor
There was a problem hiding this comment.
Here you're assuming records will always have a company_id field. How is that guaranteed? Is it coming from a mixin? 🤔 Whenever company_id is used in this addon, you should take this into consideration.
| for record in records: | ||
| # Get configuration for record company | ||
| config = configs.filtered( | ||
| lambda conf, record=record: conf.company_id == record.company_id |
Contributor
There was a problem hiding this comment.
again, record.company_id, how is that guaranteed?
| if not record.filtered_domain(domain): | ||
| continue | ||
| # Mark as printed | ||
| record.write({"printed": True}) |
Contributor
There was a problem hiding this comment.
Suggested change
| record.write({"printed": True}) | |
| record.printed = True |
Comment on lines
+84
to
+94
| if config.report_printed_log_active: | ||
| self.env["report.printed.log"].sudo().create( | ||
| { | ||
| "res_model": model_name, | ||
| "res_id": record.id, | ||
| "report_id": report.id, | ||
| "user_id": self.env.user.id, | ||
| "company_id": record.company_id.id, | ||
| "name": getattr(record, "name", record.display_name), | ||
| } | ||
| ) |
Contributor
There was a problem hiding this comment.
For performance reasons, you could gather all the data required to create the log records and then create them in batch.
| name="report_id" | ||
| domain="[('model', '=', parent.model)]" | ||
| /> | ||
| <field name="domain" /> |
Contributor
There was a problem hiding this comment.
Suggested change
| <field name="domain" /> | |
| <field name="domain" widget="domain"/> |
| <field name="create_date" /> | ||
| <field name="report_id" /> | ||
| <field name="user_id" /> | ||
| <field name="company_id" /> |
Contributor
There was a problem hiding this comment.
Suggested change
| <field name="company_id" /> | |
| <field name="company_id" groups="base.group_multi_company"/> |
| "installable": True, | ||
| "application": False, | ||
| "development_status": "Alpha", | ||
| "images": ["static/description/icon.png"], |
Contributor
There was a problem hiding this comment.
Suggested change
| "images": ["static/description/icon.png"], |
| "views/menu_views.xml", | ||
| ], | ||
| "installable": True, | ||
| "application": False, |
Contributor
There was a problem hiding this comment.
Suggested change
| "application": False, |
| "author": "Binhex Systems Solutions S.L, Odoo Community Association (OCA)", | ||
| "website": "https://github.com/OCA/reporting-engine", | ||
| "depends": [ | ||
| "base", |
Contributor
There was a problem hiding this comment.
You mentioned before that this was dependent on the web addon, didn't you?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@BinhexTeam
This module provides a reusable framework to track printed QWeb PDF
reports across business models.
It introduces configurable printed tracking with optional logging
and reusable integration through a generic mixin.
Features
Included components
report.printed.configreport.printed.config.linereport.printed.logreport.printed.mixinDesign considerations
The implementation is intentionally generic and reusable.
The module:
Technical details
ir.actions.reportqweb-pdf)Many2oneReferencefor generic log linkageFuture extensions
This module is designed to be extended by modules such as:
report_printed_flag_accountreport_printed_flag_stockDependencies
Testing
Includes automated tests covering:
Checklist