[18.0][ADD] web_chat_separate_group

[Hugo-Trentesaux]

Separates group chat and direct message in mail left panel.

[etobella]

@Hugo-Trentesaux Can you rename the commits for the usual codenames in OCA? in this case, only one commit with [ADD] web_chat_separate_group. Can you check the tests and pre-commit please too

For pre-commit you can make pre-commit install locally and pre-commit run -a to review the errors (and they will be checked anytime you try to make a commit)

[Hugo-Trentesaux]

only one commit with [ADD] web_chat_separate_group

Isn't there a "squash" option on github too? On gitlab this allows to have a single commit with the name of the merge request when merging. I'll do.

Can you check the tests and pre-commit please too

I did. And the failing tests seem to be in other modules, do I need to fix them to? Seems more suited to an other PR.

[etobella]

/ocabot rebase

[OCA-git-bot]

Congratulations, PR rebased to 18.0.

[etobella]

pre-commit error comes from the fact of using a .js file directly, you should use esm.js

/home/runner/work/web/web/web_chat_separate_group/static/src/discuss_patch.js
1:1 error Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

[etobella]

Tests were fixed with rebase. Please squash the commits in a single one and fix pre-commit with my comments (you can check locally by using pre-commit run -a )

[Hugo-Trentesaux]

1. squashed all commits into [ADD] web_chat_separate_group
2. renamed .js to .esm.js
3. ran pre-commit
4. CI tests are now ok. However, I did not add automated tests over the new layout.

[etobella]

Well, tests would be awesome if possible 😄

by default, the current system does not show automated testing on JS. Would be nice to have it, but it doesn't

[Hugo-Trentesaux]

I asked Claude code to write tests for my code, checked them, and added them in a new commit after rebasing on 18.0.

[etobella]

@Hugo-Trentesaux can you do something like this to execute the JS tests in the unit test?

https://github.com/OCA/automation/blob/18.0/automation_oca/tests/test_js.py

Also, squash your commits together if possible