[19.0][MIG] web_theme_classic: Migration to 19.0#3547
Open
jarmokortetjarvi wants to merge 32 commits into
Open
[19.0][MIG] web_theme_classic: Migration to 19.0#3547jarmokortetjarvi wants to merge 32 commits into
jarmokortetjarvi wants to merge 32 commits into
Conversation
…lds in Odoo form views
… as the field has now a background-color
Co-authored-by: Rémi <30716308+remi-filament@users.noreply.github.com>
Refactor all selectors to mirror the way odoo sets them. This results in a MUCH broader application of our styles that is not limited to form views. Prefix all vars with "wtc-" in order to prevent them from overriding or being overridden by bootstrap vars. Suffix all vars with !default to ensure that they can be overriden by dark mode. Add $wtc-input-color-required to ensure text contrasts on $wtc-input-background-color-required. This is especially necessary in instances like the quantity and unit price columns of a sale order because by default these fields are set to a light blue. Remove border on .note-editable, i.e. the HTML editor. This feature was broken and, as far as I am concerned, unnecessary. Remove all button customization as it was all broken and is superceeded by OCA/web/web_save_discard_button anyways.
web_dark_mode is not merged yet. OCA#3324
Now you can either enable by user with Classic Theme Persistent setting, or toggle it on and off like dark mode. It uses a cookie to remember your preference between reloads.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-18.0/web-18.0-web_theme_classic Translate-URL: https://translation.odoo-community.org/projects/web-18-0/web-18-0-web_theme_classic/
Currently translated at 100.0% (7 of 7 strings) Translation: web-18.0/web-18.0-web_theme_classic Translate-URL: https://translation.odoo-community.org/projects/web-18-0/web-18-0-web_theme_classic/it/
45 tasks
Contributor
|
@jarmokortetjarvi could you please update the title to : [19.0][MIG] web_theme_classic: Migration to 19.0 |
BhaveshHeliconia
approved these changes
May 13, 2026
Contributor
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
There was a problem hiding this comment.
Code and functional review LGTM!
jarmokortetjarvi
changed the title
jarmokortetjarvi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes from
18.0:View
view_users_form_simple_modifpersistent_classic_themeinsidepreferences_pagepage instead of non-existing grouppreferencesView
view_users_form_simple_modifpersistent_classic_themeinsideother_preferencesgroup instead of after non-existing fieldaction_idhttps://github.com/OCA/web/compare/18.0...jarmokortetjarvi:web:19.0-mig-web_theme_classic?expand=1