-
-
Notifications
You must be signed in to change notification settings - Fork 726
[18.0][MIG] website_require_login: Migration to 18.0 #1077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] website_require_login: Migration to 18.0 #1077
Conversation
ade8ed6 to
b1b5e11
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
|
@OCA/website-maintainers |
b1b5e11 to
7078bf9
Compare
jguenat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional & code review
LGTM
eduezerouali-tecnativa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
@Tecnativa TT58469
|
/ocabot migration website_require_login |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-1077-by-pedrobaeza-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
7078bf9 to
ffc149b
Compare
|
rebased |
|
Please check CI. |
|
@pedrobaeza Anyway, it needs to be addressed before we can merge this one, right? It seems to be the same issue we’ve seen here: |
|
Yes, it should be addressed |
|
I’m a bit short on time right now... but I’m happy to support and help as much as I can. As you’ve been involved in website_snippet_country_dropdown, would somebody of you be willing to assist in providing a fix for its test? That would be great! |
Currently translated at 100.0% (13 of 13 strings) Translation: website-14.0/website-14.0-website_require_login Translate-URL: https://translation.odoo-community.org/projects/website-14-0/website-14-0-website_require_login/it/
[UPD] Update website_require_login.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: website-16.0/website-16.0-website_require_login Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_require_login/ [UPD] README.rst
Translated using Weblate (Spanish) Currently translated at 100.0% (13 of 13 strings) Translation: website-16.0/website-16.0-website_require_login Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_require_login/es/ Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: website-16.0/website-16.0-website_require_login Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_require_login/
[UPD] Update website_require_login.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: website-17.0/website-17.0-website_require_login Translate-URL: https://translation.odoo-community.org/projects/website-17-0/website-17-0-website_require_login/
ffc149b to
69a0eda
Compare
|
@pilarvargas-tecnativa |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 8c33b91. Thanks a lot for contributing to OCA. ❤️ |
|
@pedrobaeza |
migration to 18.0