Skip to content

Conversation

@NICO-SOLUTIONS
Copy link
Member

migration to 18.0

@NICO-SOLUTIONS NICO-SOLUTIONS marked this pull request as ready for review December 9, 2024 15:17
@NICO-SOLUTIONS NICO-SOLUTIONS mentioned this pull request Dec 9, 2024
11 tasks
@NICO-SOLUTIONS NICO-SOLUTIONS force-pushed the 18.0-mig-website_require_login branch from ade8ed6 to b1b5e11 Compare February 4, 2025 14:43
@github-actions
Copy link

github-actions bot commented Jun 8, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 8, 2025
@NICO-SOLUTIONS
Copy link
Member Author

@OCA/website-maintainers
could you remove the stale tag please?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 6, 2025
@NICO-SOLUTIONS NICO-SOLUTIONS force-pushed the 18.0-mig-website_require_login branch from b1b5e11 to 7078bf9 Compare August 23, 2025 09:08
Copy link
Member

@jguenat jguenat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional & code review
LGTM

Copy link
Contributor

@eduezerouali-tecnativa eduezerouali-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@Tecnativa TT58469

@pedrobaeza
Copy link
Member

/ocabot migration website_require_login
/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-1077-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Oct 16, 2025
OCA-git-bot added a commit that referenced this pull request Oct 16, 2025
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-1077-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@NICO-SOLUTIONS
Copy link
Member Author

rebased

@pedrobaeza
Copy link
Member

Please check CI.

@NICO-SOLUTIONS
Copy link
Member Author

@pedrobaeza
I checked the CI.
The failure is coming from website_snippet_country_dropdown (TestUi.test_01_demo_country_dropdown_tour), not from website_require_login.

Anyway, it needs to be addressed before we can merge this one, right?

It seems to be the same issue we’ve seen here:
#1115

@pedrobaeza
Copy link
Member

Yes, it should be addressed

@NICO-SOLUTIONS
Copy link
Member Author

I’m a bit short on time right now... but I’m happy to support and help as much as I can.
@yajo
@ernestotejeda
@CarlosRoca13
@pilarvargas-tecnativa

As you’ve been involved in website_snippet_country_dropdown, would somebody of you be willing to assist in providing a fix for its test? That would be great!

hailangvn and others added 6 commits October 17, 2025 12:35
[UPD] Update website_require_login.pot

[UPD] README.rst

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: website-16.0/website-16.0-website_require_login
Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_require_login/

[UPD] README.rst
Translated using Weblate (Spanish)

Currently translated at 100.0% (13 of 13 strings)

Translation: website-16.0/website-16.0-website_require_login
Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_require_login/es/

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: website-16.0/website-16.0-website_require_login
Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_require_login/
[UPD] Update website_require_login.pot

[BOT] post-merge updates

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: website-17.0/website-17.0-website_require_login
Translate-URL: https://translation.odoo-community.org/projects/website-17-0/website-17-0-website_require_login/
@NICO-SOLUTIONS NICO-SOLUTIONS force-pushed the 18.0-mig-website_require_login branch from ffc149b to 69a0eda Compare October 17, 2025 10:36
@NICO-SOLUTIONS
Copy link
Member Author

@pilarvargas-tecnativa
thanks a lot pilar! Your quick response and solution is awesome!

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-1077-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d09b574 into OCA:18.0 Oct 17, 2025
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8c33b91. Thanks a lot for contributing to OCA. ❤️

@NICO-SOLUTIONS
Copy link
Member Author

@pedrobaeza
thx a lot for all your input!

@NICO-SOLUTIONS NICO-SOLUTIONS deleted the 18.0-mig-website_require_login branch October 17, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants