Skip to content

Stop pushing to ECR #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndp-opendap merged 3 commits into from
Mar 19, 2026
Merged

Stop pushing to ECR #84

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b66a940
Disabled bundled Tomcat auth
ndp-opendap Nov 5, 2025
4a7f96c
Merged master to stop_with_ecr
ndp-opendap Mar 4, 2026
08dc7d5
Made pusing to ECR a conditional operation.
ndp-opendap Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions travis/deploy_to_docker_hub.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ prolog="deploy_to_docker_hub.sh"
function loggy(){
echo "$@" | awk -v prolog="$prolog" '{ print "# " prolog " - " $0;}' >&2
}

PUSH_TO_ECR="${PUSH_TO_ECR:-""}"

loggy "$HR0"
loggy "BEGIN"

Expand Down Expand Up @@ -53,18 +56,20 @@ fi

loggy "Docker Hub deployment complete."
loggy "$HR1"
loggy "PUSH_TO_ECR: '$PUSH_TO_ECR'"
loggy "SNAPSHOT_IMAGE_TAG: '$SNAPSHOT_IMAGE_TAG'"



if test -n "$SNAPSHOT_IMAGE_TAG"
if [[ -n "$PUSH_TO_ECR" && -n "$SNAPSHOT_IMAGE_TAG" ]]
then
loggy "AWS configuration: "
loggy "$(aws configure list)"
loggy "OPENDAP_AWS_ACCOUNT: $OPENDAP_AWS_ACCOUNT"
loggy "Deploying ${SNAPSHOT_IMAGE_TAG} to AWS ECR"
loggy "Pushing $SNAPSHOT_IMAGE_TAG to AWS ECR"
docker tag "$SNAPSHOT_IMAGE_TAG" "$OPENDAP_AWS_ACCOUNT.dkr.ecr.us-east-1.amazonaws.com/$SNAPSHOT_IMAGE_TAG"
docker push "$OPENDAP_AWS_ACCOUNT.dkr.ecr.us-east-1.amazonaws.com/$SNAPSHOT_IMAGE_TAG"
loggy "AWS ECR deployment complete."
else
loggy "No images pushed to ECR."
fi

loggy "END"
Expand Down