Add support for the autotools build with vscode.#336
Merged
jgallagher59701 merged 8 commits intomasterfrom Mar 2, 2026
Merged
Conversation
I may have to drop back to -O0 for developer builds to get decent OSX builds. The command to make the dSYM lib was: dsymutil .libs/libdap.27.dylib -o .libs/libdap.27.dylib.dSYM
|
hannahilea
reviewed
Mar 2, 2026
| */.DS_Store | ||
| .idea | ||
| .dirstamp | ||
| .vscode/ |
Contributor
There was a problem hiding this comment.
do we still want this in here? I guess we probably do, given that changes to the new .vscode files will still be tracked.
Member
Author
There was a problem hiding this comment.
Maybe, I don't know. This stuff seems different somehow. This might evolve - it might be that some of the files should be in version control. Others not.
hannahilea
reviewed
Mar 2, 2026
.vscode/launch.json
Outdated
| }, | ||
| { | ||
| "name": "PATH", | ||
| "value": "/Users/jimg/src/opendap/hyrax/build/bin:/Users/jimg/src/opendap/hyrax/build/deps/bin:${env:PATH}" |
Contributor
There was a problem hiding this comment.
at the very least, should probably replace the "/Users/jimg/"s with "~"?
hannahilea
reviewed
Mar 2, 2026
.vscode/settings.json
Outdated
| "C_Cpp.default.intelliSenseMode": "macos-clang-arm64", | ||
| "terminal.integrated.env.osx": { | ||
| "prefix": "/Users/jhrg/src/opendap/hyrax/build", | ||
| "PATH": "/Users/jhrg/src/opendap//hyrax/build/bin:/Users/jhrg/src/opendap/hyrax/build/deps/bin:${env:PATH}" |
Contributor
There was a problem hiding this comment.
ditto, replace out /Users/jhrg with "~"?
hannahilea
approved these changes
Mar 2, 2026
Contributor
hannahilea
left a comment
hannahilea
left a comment
There was a problem hiding this comment.
Pre-merge, consider:
- replacing jhrg-specific paths with generic
- adding a brief blurb to the README explaining that debugging functionality has been added via the vscode folder, plus disclaimer about being OSX-specific (probably)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch: jhrg/vscode-1
All the configuration info is in libdap4/.vscode. There are no changes to the Makefile.am, configure.ac, etc.
This really needs some documentation, but I'd like to see how it fares with CICD.