Move getAutoChokeGroupProductionTargetRate() to GroupStateHelper#6837
Merged
totto82 merged 1 commit intoOPM:masterfrom Feb 20, 2026
Merged
Move getAutoChokeGroupProductionTargetRate() to GroupStateHelper#6837totto82 merged 1 commit intoOPM:masterfrom
totto82 merged 1 commit intoOPM:masterfrom
Conversation
hakonhagland
added
the
manual:irrelevant
Contributor
Author
|
jenkins build this serial please |
Contributor
Author
|
Putting this in draft mode until #6835 has been merged |
hakonhagland
force-pushed
the
refact_wgc
branch
from
7d49cbb to
a15d524
Compare
Contributor
Author
|
jenkins build this serial please |
Move getAutoChokeGroupProductionTargetRate() from WellGroupControls (static method) to GroupStateHelper (member method). The method has no well dependency and manually reimplements chain iteration already available as applyReductionsAndFractions_(). The moved implementation delegates to applyReductionsAndFractions_() with do_addback=false and the actual getLocalReductionLevel_() value, replacing the manual reduction loop. Make getLocalReductionLevel_() private again (reverting the visibility change from the previous commit), since its only external caller was the now-removed static method in WellGroupControls. Remove unused FractionCalculator.hpp include from WellGroupControls.cpp and WellGroupControls.hpp include from BlackoilWellModelNetwork_impl.hpp and the test file.
hakonhagland
force-pushed
the
refact_wgc
branch
from
a15d524 to
7abd6f9
Compare
Contributor
Author
|
jenkins build this serial please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #6835 which should be merged first.
Move
getAutoChokeGroupProductionTargetRate()fromWellGroupControls(static method) toGroupStateHelper(member method). The method has no well dependency and manually reimplements chain iteration already available asapplyReductionsAndFractions_().Delegate to
applyReductionsAndFractions_()withdo_addback=falseand the actualgetLocalReductionLevel_()value, replacing the manual reduction loop.Make
getLocalReductionLevel_()private again, reverting the visibility change from Add tests and fix autochoke group target rate #6835, since its only external caller was the now-removed static method inWellGroupControls.