Skip to content

Fix CMake linking for rocalution, rocblas and rocsparse.#6842

Merged
blattms merged 1 commit intoOPM:masterfrom
blattms:bugfix/fix-roc-linking
Feb 24, 2026
Merged

Fix CMake linking for rocalution, rocblas and rocsparse.#6842
blattms merged 1 commit intoOPM:masterfrom
blattms:bugfix/fix-roc-linking

Conversation

@blattms
Copy link
Copy Markdown
Member

@blattms blattms commented Feb 18, 2026

We cannot rely on finding them via hip. A found HIP might even be pulled in by dependencies.

For me the rocalution target was not there but hip was somehow found.

@blattms blattms added the manual:irrelevant This PR is a minor fix and should not appear in the manual label Feb 18, 2026
@blattms
Copy link
Copy Markdown
Member Author

blattms commented Feb 18, 2026

jenkins build this please

Comment thread CMakeLists.txt Outdated
Comment thread CMakeLists.txt Outdated
Comment thread CMakeLists.txt
We cannot rely on finding this via hip. A found HIP mighr even
be pulled in by dependencies.
@blattms blattms force-pushed the bugfix/fix-roc-linking branch from 9be5764 to 2b6f9b2 Compare February 19, 2026 13:38
@blattms
Copy link
Copy Markdown
Member Author

blattms commented Feb 19, 2026

jenkins build this please

@blattms blattms merged commit 0260ce5 into OPM:master Feb 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manual:irrelevant This PR is a minor fix and should not appear in the manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants