Skip to content

gnm: avoid redundant root path cost re-summation in KShortestPaths#14091

Open
KinshukSS2 wants to merge 1 commit intoOSGeo:masterfrom
KinshukSS2:fix/gnm-kshortest-paths-redundant-cost-summation
Open

gnm: avoid redundant root path cost re-summation in KShortestPaths#14091
KinshukSS2 wants to merge 1 commit intoOSGeo:masterfrom
KinshukSS2:fix/gnm-kshortest-paths-redundant-cost-summation

Conversation

@KinshukSS2
Copy link
Copy Markdown
Contributor

@KinshukSS2 KinshukSS2 commented Mar 8, 2026

description

the current method to find costs was that whenever a path was found then it usually checks the cost from the start thus making it less efficient

the fix i propose usually only plays a better role when there is a presence of long paths in large GNM networks
it basically only finds the cost for the new branches whenever created

fixes #14090

@rouault
Copy link
Copy Markdown
Member

rouault commented Mar 8, 2026

CC @BishopGIS

@KinshukSS2
Copy link
Copy Markdown
Contributor Author

any updates on the status of the pr...pls let me know if any changes are required from my side

@jratike80
Copy link
Copy Markdown
Collaborator

any updates on the status of the pr...

Waiting for someone to review. You know, this is open source, there are not many people who know gnm well, and there are also other things going on https://github.com/OSGeo/gdal/pulse.

@rouault
Copy link
Copy Markdown
Member

rouault commented Apr 2, 2026

@BishopGIS Still available for GNM related topics ?

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

The GDAL project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 28 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular link
    to any issues which this pull request fixes

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in 2 weeks.

@github-actions github-actions Bot added the stale label May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

# GNMGraph::KShortestPaths redundantly re-sums root path cost on every spur iteration

3 participants