fixes Path Traversal + ZIP Slip allow arbitrary filesystem read/write…#35
Open
arnchlmcodes wants to merge 1 commit intoOSeMOSYS:masterfrom
Open
fixes Path Traversal + ZIP Slip allow arbitrary filesystem read/write…#35arnchlmcodes wants to merge 1 commit intoOSeMOSYS:masterfrom
arnchlmcodes wants to merge 1 commit intoOSeMOSYS:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34
Summary
This PR fixes multiple security vulnerabilities involving path traversal and ZIP Slip attacks that could allow arbitrary filesystem read/write.
Changes
Security Improvements
Securityhelper class with:safeCasePath(baseDir, casename)- ensures resolved paths remain inside the intended directory (prevents../traversal).safeExtractall(zf, targetDir)- validates ZIP entries before extraction to prevent ZIP Slip attacks.Path Traversal Protection
Security.safeCasePath()validation to routes handling user-supplied paths:backupCase())Requests attempting directory escape now return HTTP 400.
ZIP Extraction Hardening
zf.extractall()usage withSecurity.safeExtractall()in:uploadCaseUnchunked_old()handle_full_zip()Upload Size Limiting
Updated Flask configuration:
Prevents unbounded file uploads.