Skip to content

Conversation

@charan255
Copy link

Proposed change

This PR adds a new localization file tel.yaml, providing complete Telugu (te-IN) translations for all strings used in Nettacker.
The file follows the exact structure of the English YAML and covers API messages, scan outputs, errors, module texts, and CLI prompts.

This improves accessibility of Nettacker for Telugu-speaking users in India and supports OWASP’s ongoing i18n efforts.
Your PR description goes here.

Type of change

  • New core framework functionality
  • Bugfix (non-breaking change which fixes an issue)
  • Code refactoring without any functionality changes
  • New or existing module/payload change
  • Documentation/localization improvement
  • Test coverage improvement
  • Dependency upgrade
  • Other improvement (best practice, cleanup, optimization, etc)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

The file contains the contents of "en.yaml" so that each line can be translated using a reference sentence.

Signed-off-by: Charan Tej P <charantejpappuleti255@gmail.com>
All the API messages have successfully been translated. Needs a review before submitting a PR to the nettacker repo.

Signed-off-by: Charan Tej P <charantejpappuleti255@gmail.com>
complete Telugu localization for API messages
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 4, 2025

Summary by CodeRabbit

  • New Features
    • Added Telugu language support with complete translations for user interface prompts, error messages, module execution notifications, and output formatting.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

Added a new Telugu locale file providing translations for UI and runtime messages; no code logic or control flow changes were made.

Changes

Cohort / File(s) Change Summary
Telugu Locale Translations
nettacker/locale/tel.yaml
New YAML locale file adding comprehensive Telugu translations for API options, graph messages, module execution logs, error messages, help text, scan options, output formatting, and other user-facing strings.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Check YAML syntax and indentation.
  • Confirm presence and consistency of keys versus other locale files.
  • Spot-check a few translations for correct key-to-string mapping.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and accurately describes the main change: adding a Telugu translation file (tel.yaml) with the language code te-IN.
Description check ✅ Passed The description is clearly related to the changeset, explaining the purpose of the new localization file, its coverage, and benefits for Telugu-speaking users.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ca317da and 3da2e1b.

📒 Files selected for processing (1)
  • nettacker/locale/tel.yaml (1 hunks)
🧰 Additional context used
🪛 Checkov (3.2.334)
nettacker/locale/tel.yaml

[medium] 68-69: Basic Auth Credentials

(CKV_SECRET_4)

🪛 YAMLlint (1.37.1)
nettacker/locale/tel.yaml

[error] 102-102: syntax error: expected , but found ''

(syntax)

🔇 Additional comments (1)
nettacker/locale/tel.yaml (1)

1-127: Verify YAML file syntax and address outstanding static analysis errors.

The file appears structurally sound, but there are two static analysis alerts that need verification:

  1. Checkov CKV_SECRET_4 (lines 68-69) — This is a false positive. The alert flags proxy authentication example text (socks://username:password@...) which is legitimate documentation showing the expected format, not an actual hardcoded credential.

  2. YAMLlint syntax error (line 102) — This requires verification. The error message ("expected , but found ''") typically indicates either a missing EOF newline, indentation inconsistency, or an unclosed block. Please run the verification script above to confirm the exact nature of the error.

  3. Line 74 fix verification — The previous review flagged an unquoted colon in ports_int. This appears to be fixed in the current version (the value is now quoted), which is correct.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 65bf88e and ca317da.

📒 Files selected for processing (1)
  • nettacker/locale/tel.yaml (1 hunks)
🧰 Additional context used
🪛 Checkov (3.2.334)
nettacker/locale/tel.yaml

[medium] 68-69: Basic Auth Credentials

(CKV_SECRET_4)

🪛 YAMLlint (1.37.1)
nettacker/locale/tel.yaml

[error] 74-74: syntax error: mapping values are not allowed here

(syntax)

🔇 Additional comments (2)
nettacker/locale/tel.yaml (2)

66-69: File does not exist in the repository.

The file nettacker/locale/tel.yaml referenced in this review comment does not exist in the repository. The locale directory contains 24 language files (ar.yaml, bn.yaml, de.yaml, etc.), but no tel.yaml file. If a Telugu locale file were to be added, it should use the standard language code "te" (not "tel"), resulting in a filename like te.yaml.

Likely an incorrect or invalid review comment.


28-28: No action required on line 28.

The placeholder "{0}" is a standard positional placeholder used in localization frameworks (MessageFormat, Java, .NET, ICU) for runtime argument substitution. This pattern is intentional and correctly formatted, not an incomplete translation.

Likely an incorrect or invalid review comment.

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Signed-off-by: Charan Tej P <charantejpappuleti255@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant