Open
Conversation
Jtango18
approved these changes
Apr 14, 2026
Jtango18
requested changes
Apr 14, 2026
Contributor
Jtango18
left a comment
There was a problem hiding this comment.
Looks like some build issues
There was a problem hiding this comment.
Pull request overview
Migrates Calamari’s build infrastructure from Nuke.Common to the internal fork Octopus.Nuke.Common, and updates NuGet source/mapping configuration to support restoring the forked package.
Changes:
- Update build project to reference
Octopus.Nuke.Common(and adjust solution injection accordingly). - Consolidate NuGet restore behavior by removing
build/NuGet.Configand updating rootNuGet.Configsources/mappings. - Update third-party credits to reflect the new build dependency.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| credits/credits.md | Replaces Nuke.Common credit entry with Octopus.Nuke.Common. |
| build/_build.csproj | Switches build dependency to Octopus.Nuke.Common and adds an MSBuild property tweak. |
| build/NuGet.Config | Removes build-local NuGet configuration file. |
| build/GlobalUsings.cs | Adds Nuke.Common.ProjectModel global using to support solution injection usage. |
| build/Build.cs | Moves from manually parsing the solution to [Solution] injection. |
| NuGet.Config | Adds <clear /> and maps Octopus.Nuke.* to feedz.io. |
Comments suppressed due to low confidence (1)
NuGet.Config:37
- Because the NuGet.org packageSourceMapping includes a wildcard "", packages matching "Octopus.Nuke." are still permitted to restore from NuGet.org as well as feedz.io. If the intent is to ensure the internal fork is always sourced from feedz.io, the mapping needs to be tightened so Octopus.Nuke.* cannot also match the NuGet.org source (e.g., avoid using a catch-all "" on NuGet.org, or replace it with explicit patterns and keep Octopus. constrained to feedz).
<package pattern="Octopus.Nuke.*" />
</packageSource>
<packageSource key="NuGet.org v3">
<package pattern="NuGet.Common" />
<package pattern="NuGet.Configuration" />
<package pattern="NuGet.Frameworks" />
<package pattern="NuGet.Packaging" />
<package pattern="NuGet.Protocol" />
<package pattern="NuGet.Versioning" />
<package pattern="Octopus.Versioning" />
<package pattern="Octopus.TinyTypes" />
<package pattern="*" />
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Jtango18
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate from
Nuke.Common9.0.4 toOctopus.Nuke.Common10.1.14 (our internal fork as the OSS version is not actively maintained)