Skip to content

Update Calamari to use Nuke fork#1882

Open
sathvikkumar-octo wants to merge 5 commits intomainfrom
sk/nuke-fork
Open

Update Calamari to use Nuke fork#1882
sathvikkumar-octo wants to merge 5 commits intomainfrom
sk/nuke-fork

Conversation

@sathvikkumar-octo
Copy link
Copy Markdown
Contributor

Migrate from Nuke.Common 9.0.4 to Octopus.Nuke.Common 10.1.14 (our internal fork as the OSS version is not actively maintained)

@sathvikkumar-octo sathvikkumar-octo changed the title Update to Nuke fork Update Calamari to use Nuke fork Apr 14, 2026
Copy link
Copy Markdown
Contributor

@Jtango18 Jtango18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some build issues

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates Calamari’s build infrastructure from Nuke.Common to the internal fork Octopus.Nuke.Common, and updates NuGet source/mapping configuration to support restoring the forked package.

Changes:

  • Update build project to reference Octopus.Nuke.Common (and adjust solution injection accordingly).
  • Consolidate NuGet restore behavior by removing build/NuGet.Config and updating root NuGet.Config sources/mappings.
  • Update third-party credits to reflect the new build dependency.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
credits/credits.md Replaces Nuke.Common credit entry with Octopus.Nuke.Common.
build/_build.csproj Switches build dependency to Octopus.Nuke.Common and adds an MSBuild property tweak.
build/NuGet.Config Removes build-local NuGet configuration file.
build/GlobalUsings.cs Adds Nuke.Common.ProjectModel global using to support solution injection usage.
build/Build.cs Moves from manually parsing the solution to [Solution] injection.
NuGet.Config Adds <clear /> and maps Octopus.Nuke.* to feedz.io.
Comments suppressed due to low confidence (1)

NuGet.Config:37

  • Because the NuGet.org packageSourceMapping includes a wildcard "", packages matching "Octopus.Nuke." are still permitted to restore from NuGet.org as well as feedz.io. If the intent is to ensure the internal fork is always sourced from feedz.io, the mapping needs to be tightened so Octopus.Nuke.* cannot also match the NuGet.org source (e.g., avoid using a catch-all "" on NuGet.org, or replace it with explicit patterns and keep Octopus. constrained to feedz).
      <package pattern="Octopus.Nuke.*" />
    </packageSource>
    <packageSource key="NuGet.org v3">
      <package pattern="NuGet.Common" />
      <package pattern="NuGet.Configuration" />
      <package pattern="NuGet.Frameworks" />
      <package pattern="NuGet.Packaging" />
      <package pattern="NuGet.Protocol" />
      <package pattern="NuGet.Versioning" />
      <package pattern="Octopus.Versioning" />
      <package pattern="Octopus.TinyTypes" />
      <package pattern="*" />

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants