Add information to GitHub Connections for allow lists#3094
Draft
stevencl840 wants to merge 6 commits intomainfrom
Draft
Add information to GitHub Connections for allow lists#3094stevencl840 wants to merge 6 commits intomainfrom
stevencl840 wants to merge 6 commits intomainfrom
Conversation
stevencl840
force-pushed
the
sjc/update-githubconnection-allowlist
branch
from
d165c9a to
af27aac
Compare
stevencl840
force-pushed
the
sjc/update-githubconnection-allowlist
branch
from
af27aac to
4a35536
Compare
|
|
||
| ## Allow List | ||
|
|
||
| The Octopus Deploy GitHub App can be used with the GitHub Enterprise allow list feature. To include the app in your allow list manually add the IP Address `172.182.208.68`. Due to a limitation in the way that GitHub supports inheritance of IP addresses when performing actions on behalf of a user, the IP address for the GitHub App needs to be configured manually and cannot be inherited from the app settings. For more information please refer to [GitHub's Documentation](https://docs.github.com/en/enterprise-cloud@latest/apps/maintaining-github-apps/managing-allowed-ip-addresses-for-a-github-app#about-ip-address-allow-lists-for-github-apps) |
Contributor
There was a problem hiding this comment.
I think I would probably put the bit about the limitation in a separate paragraph, and maybe as some sort of information note like the one below? Just to differentiate it from the main content which is the IP address.
Contributor
Author
There was a problem hiding this comment.
Having two information blocks in that close of proximity made it look weird (in my opinion). I have split it into two paragraphs and placed the info block between them. I think breaking it up actually draws more attention to the second paragraph
|
|
||
| ## Allow List | ||
|
|
||
| The Octopus Deploy GitHub App can be used with the GitHub Enterprise allow list feature. To include the app in your allow list manually add the IP Address `172.182.208.68`. Due to a limitation in the way that GitHub supports inheritance of IP addresses when performing actions on behalf of a user, the IP address for the GitHub App needs to be configured manually and cannot be inherited from the app settings. For more information please refer to [GitHub's Documentation](https://docs.github.com/en/enterprise-cloud@latest/apps/maintaining-github-apps/managing-allowed-ip-addresses-for-a-github-app#about-ip-address-allow-lists-for-github-apps) |
Contributor
There was a problem hiding this comment.
A few other thoughts:
- Can we add a link to the GitHub docs on how to add the IP address to an enterprise or org?
- Is "GitHub Enterprise allow list" the name of the feature in GitHub? Might be worth checking what they call it and adjusting if needed.
Contributor
Author
There was a problem hiding this comment.
- I have added the link to githubs documentation
- They refer to it as allow list, or allow list IP. I have removed the reference to enterprise
… github app registration stand out
geofflamrock
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context 🌇
We have updated the GitHub App so that all traffic from the App to GitHub now passes through a known IP. This allows customers using GitHub Enterprise to enable allow lists and, by adding this IP, still use the GitHub App to manage connections to their repositories.
This PR will closes devex-5