feat: add test connection button to JWT build feature#24
feat: add test connection button to JWT build feature#24matt-richardson merged 4 commits intomainfrom
Conversation
Adds a "Test" button to the build feature configuration page that: - issues a dry-run JWT using the current feature settings - verifies the OIDC discovery and JWKS endpoints are reachable - optionally exchanges the JWT for an access token at a given service URL (requires HTTPS; Content-Type: application/json for Octopus compatibility) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mattburnell
left a comment
There was a problem hiding this comment.
Feature and tests look really good. Claude was bothered by what it sees as a moderate SSRS attack (by allowing non-https traffic for localhost URLs, anyone with MANAGE_SERVER_INSTALLATION can use the service to probe local HTTP endpoints). While the test logic looks thorough, I feel the readability could be substantially improved by encapsulating some of the setup/teardown logic into higher-order functions.
I removed the support for isLocalHost, and switched the tests to use mocking instead.
Done. Removed ~200 lines from the PR 😄 |
Summary
Content-Type: application/x-www-form-urlencodedper RFC 8693)Test plan
🤖 Generated with Claude Code