Open
Conversation
Wrong regexp was used so if iconv is not present then the tests fail.
Don't try to require iconv on browser environments in the first place. Not sure how to make iconv-lite properly configurable at runtime though.
Remove the need for a polyfill by providing an implementation that uses web APIs.
vlovich
force-pushed
the
browser-compat
branch
from
b3335ef to
941ae92
Compare
Author
|
This can still hit #7 for Cloudflare Workers from my experiments. Not sure how to do anything other than patching out the iconv-lite |
Author
|
Another thing I'll mention is that the primary reason for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #7 and #8 by adding support for targeting the browser environment.
Note that iconv-lite is also made optional in case the downstream user doesn't want to take the size hit and is fine only supporting UTF-8 and ASCII. One open question is whether unsupported charsets should be rejected with a RangeError instead of silently failing to decode. Such a change wouldn't be backward compatible but maybe there's a "strict" option
that could be added to decode to control that behavior.