Add test that launches Oolite, creates a snapshot and closes it#591
Open
mcarans wants to merge 23 commits intoOoliteProject:masterfrom
Open
Add test that launches Oolite, creates a snapshot and closes it#591mcarans wants to merge 23 commits intoOoliteProject:masterfrom
mcarans wants to merge 23 commits intoOoliteProject:masterfrom
Conversation
Make AddOns folder in oolite.app not build Add Python test that launches Oolite, takes a snapshot and quits
Add make -f Makefile test Add to test_builds workflow Add Windows test build
Exclude AddOns in oolite.app folder as it is already one level up
Install mesa in standard install (since by default it won't be used instead of hardware acceleration)
Remove extraneous comments and improve others
phkb
requested changes
Apr 7, 2026
Contributor
phkb
left a comment
phkb
left a comment
There was a problem hiding this comment.
Other than my note below, I'm happy with the change.
| { "takeSnapShot", GlobalTakeSnapShot, 1 }, | ||
| #endif | ||
| { "pauseGame", GlobalPauseGame, 0 }, | ||
| { "quitGame", GlobalQuitGame, 0 }, |
Contributor
There was a problem hiding this comment.
I think it might be better to move the quitGame global method into the #ifndef NDEBUG section, same as the "takeSnapshot" method. It's not a function that should ever be called by a script, and will only be used in debug scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI for Linux and Windows for test
Allow Windows build to use AddOns folder in same directory (as well as one level up as now)
Expose quit function to JavaScript
Snapshot is checked - it must be a valid PNG file > 100Kb
Note Arch test is broken due to GNUstep not supporting clang 22 just yet
Example output from Windows CI test:
Example output from Ubuntu CI test: