-
Notifications
You must be signed in to change notification settings - Fork 2
Upgrading python versions (and adding nox) #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
|
.. Additionally updated |
|
Hi Dylan, a few thoughts below:
|
nick-gorman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see previous comment
|
Thanks Nick! Some responses, in order:
|
|
Hey Dylan, yep, thanks for clarifying, I'd misunderstood a few things, and it sounds good re-adding 3.10 back in. |
Closes #30 - drop support / testing of python 3.9, and 3.10 (3.9 EoL, 3.10 EoL this year, and PyPSA 1.0 requires >3.11) and add in 3.13, 3.14. Some third party libraries didn't install with 3.14t (so not supported for now).
*Discovered a significant bug in cicd.yml (we weren't actually testing different python versions, just 3.12). Hopefully also fixed / corrected (and turns out we weren't actually supporting 3.9 anyway - (some of our typing syntax requires >3.10)