Skip to content

Support for ISP Workbook version 7.5#71

Merged
nick-gorman merged 6 commits intoOpen-ISP:mainfrom
James-Aylward:workbook7.5
Jan 28, 2026
Merged

Support for ISP Workbook version 7.5#71
nick-gorman merged 6 commits intoOpen-ISP:mainfrom
James-Aylward:workbook7.5

Conversation

@James-Aylward
Copy link
Contributor

Adds configuration for ISP workbook version 7.5, used in "Draft 2026 ISP Inputs and Assumptions workbook".

@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nick-gorman
Copy link
Member

nick-gorman commented Jan 23, 2026

Thanks for PR @James-Aylward!

These updates can be a bit of a slog, so definitely appreciate the help.

Looked pretty good to me, I've just added in some extra tables and fixed some names up.

We are running into errors for the extra tables on macos though. @EllieKallmier any chance you could use your Mac to dig a bit deeper on this? It looks like on mac the table distribution_network_CER_augmentation_tranche_costs in workbook 7.5 has data after the last row, but this isn't showing up on windows.

@nick-gorman
Copy link
Member

Thanks for PR @James-Aylward!

These updates can be a bit of a slog, so definitely appreciate the help.

Looked pretty good to me, I've just added in some extra tables and fixed some names up.

We are running into errors for the extra tables on macos though. @EllieKallmier any chance you could use your Mac to dig a bit deeper on this? It looks like on mac the table distribution_network_CER_augmentation_tranche_costs in workbook 7.5 has data after the last row, but this isn't showing up on windows.

Turns out the macos error was a bug caused by configs with dupilcate names, which only showed up on macos because the config loading order was different. The bad config loaded first on mac and was used while on windows the good config was used. Changing the name of the second config and pointing it at the correct workbook sheet solved this issue.

@nick-gorman nick-gorman merged commit 51e0379 into Open-ISP:main Jan 28, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants