fix: add missing super().__init__ calls #2757
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReimarBauer
requested changes
Mar 31, 2025
Member
ReimarBauer
left a comment
ReimarBauer
left a comment
There was a problem hiding this comment.
106 failed, 463 passed, 12 skipped, 19 warnings, 13 errors in 479.55s (0:07:59)
added 2 commits
April 2, 2025 23:24
matrss
requested changes
Apr 3, 2025
Collaborator
matrss
left a comment
matrss
left a comment
There was a problem hiding this comment.
Both classes seem to have at least parts of their constructors copied over from the classes they inherit, so just calling the super classes constructor is not enough, it has to be checked what that constructor does and what ours do so far, what the differences are, and how to achieve the same result with a cleaner refactoring of these classes.
Contributor
Author
|
got it. i'll look into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?: This PR adds missing super().init() calls to ensure proper parent class initialization in MFDatasetCommonDims and WebMapService.
Bug Fix
Fixes #2750