-
Notifications
You must be signed in to change notification settings - Fork 120
show revision id in view and plot titles #2965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
show revision id in view and plot titles #2965
Conversation
mslib/mscolab/mscolab.py
Outdated
|
|
||
| def confirm_action(confirmation_prompt): | ||
| def confirm_action(confirmation_prompt, assume_yes=False): | ||
| if assume_yes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please separate this. You have this in a different PR.
mslib/mscolab/mscolab.py
Outdated
| database_parser.add_argument("--add_all_to_all_operation", help="adds all users into all other operations", | ||
| action="store_true") | ||
|
|
||
| db_actions = database_parser.add_mutually_exclusive_group(required=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not part of the issue.
We split tasks and also PRs do handle only 1 issue.
|
@ReimarBauer i have removed the |
|
Please show the ID, this will always work, because a name can be shifted over IDs. If there is a name at an ID then show it too. The feature is interesting for those comparing images, it gives the possibility to see that there was a change. |
|
While looking up the servers retrieved data I recognized that we don't have revision information yet implemented. So that is not an easy task. |
|
thanks for checking this and for the clarification. |

summary
always show the revision ID in view window titles and plot titles.
if a revision name exists, it is appended.
motivation
improves traceability when switching revisions or comparing views.
Fixes #2026