[spring] Support 'date-time-local' format#23395
[spring] Support 'date-time-local' format#23395Allsimon wants to merge 3 commits intoOpenAPITools:masterfrom
Conversation
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaCodegen.java">
<violation number="1" location="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaCodegen.java:2661">
P2: New format handling uses mismatched keys (`date-time-local` vs `local-date`), so the added `date-time-local` property post-processing branch will not execute.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| @Override | ||
| protected void updatePropertyForString(CodegenProperty property, Schema p) { | ||
| super.updatePropertyForString(property, p); | ||
| if ("local-date".equals(p.getFormat())) { |
There was a problem hiding this comment.
P2: New format handling uses mismatched keys (date-time-local vs local-date), so the added date-time-local property post-processing branch will not execute.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaCodegen.java, line 2661:
<comment>New format handling uses mismatched keys (`date-time-local` vs `local-date`), so the added `date-time-local` property post-processing branch will not execute.</comment>
<file context>
@@ -2653,4 +2654,13 @@ public void setEnumPropertyNaming(final String enumPropertyNamingType) {
+ @Override
+ protected void updatePropertyForString(CodegenProperty property, Schema p) {
+ super.updatePropertyForString(property, p);
+ if ("local-date".equals(p.getFormat())) {
+ property.setIsString(false);
+ property.isDateTime = true;
</file context>
.../openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaCodegen.java
Show resolved
Hide resolved
There was a problem hiding this comment.
I expect @wing328 to suggest to simply move this into an existing spec rather than creating a new one 😅
There was a problem hiding this comment.
Yeah I almost put it in date-time-parameter-types-for-testing.yml but wasn't sure if this was the best move, I'll update the PR 👍
.../openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaCodegen.java
Show resolved
Hide resolved
.../openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaCodegen.java
Show resolved
Hide resolved
|
https://github.com/OpenAPITools/openapi-generator/actions/runs/23816722621/job/69487441944?pr=23395 please update the samples to fix this |
| @DateTimeFormat(iso = DateTimeFormat.ISO.DATE) | ||
| private LocalDate dateOfBirth = LocalDate.parse("2021-01-01"); | ||
|
|
||
| private LocalDateTime adoptionDate = "2007-12-03T10:15:30"; |
| @DateTimeFormat(iso = DateTimeFormat.ISO.DATE) | ||
| private LocalDate dateOfBirth = LocalDate.parse("2021-01-01"); | ||
|
|
||
| private LocalDateTime adoptionDate = "2007-12-03T10:15:30"; |
See https://spec.openapis.org/registry/format/date-time-local.html
fixes #13889
@cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Add support for the OpenAPI
date-time-localformat in the Java/Spring generator. Fields with this format now generateLocalDateTimewith ajava.time.LocalDateTimeimport. Fixes #13889.date-time-local->LocalDateTimeinAbstractJavaCodegenand always importjava.time.LocalDateTime.Pet.adoptionDateisLocalDateTime.Written for commit c6859f3. Summary will update on new commits.