Skip to content

fix(python): Fix sanitize_for_serialization code generation for python client#23415

Open
w1ll-i-code wants to merge 2 commits intoOpenAPITools:masterfrom
neteye-platform:fix/23409-serialize-anyOf-primitive-values
Open

fix(python): Fix sanitize_for_serialization code generation for python client#23415
w1ll-i-code wants to merge 2 commits intoOpenAPITools:masterfrom
neteye-platform:fix/23409-serialize-anyOf-primitive-values

Conversation

@w1ll-i-code
Copy link
Copy Markdown

@w1ll-i-code w1ll-i-code commented Apr 1, 2026

fixes #23409

Makes sure that the output from the to_dict() call passes through all branches of sanitize_for_serialization to make sure primitive or list types that are returned by to_dict() by, e.g. model_anyof.mustache are handled appropriately.

@cbornet @tomplus @krjakbrjak @fa0311 @multani

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Fixes #23409. Ensures the Python client's sanitize_for_serialization fully processes to_dict() results so primitives and lists from anyOf models serialize correctly.

  • Bug Fixes
    • Route all to_dict() outputs back through sanitize_for_serialization (handles primitives and lists from anyOf).
    • Sanitize dict inputs directly and drop the list-only special case; regenerated Python samples to apply the fix.

Written for commit 2da75ec. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="modules/openapi-generator/src/main/resources/python/api_client.mustache">

<violation number="1" location="modules/openapi-generator/src/main/resources/python/api_client.mustache:385">
P1: Dict serialization references undefined `obj_dict`, causing NameError when sanitizing dict inputs.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@w1ll-i-code w1ll-i-code force-pushed the fix/23409-serialize-anyOf-primitive-values branch from 1f21616 to bcda8e4 Compare April 1, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][PYTHON] Exception when serializing any_of with primitive types

2 participants