Skip to content

feat(rust-server): refactor server module templates to avoid a monolithic run function.#23432

Draft
dsteeley wants to merge 1 commit intoOpenAPITools:masterfrom
dsteeley:refactor-rust-server-server
Draft

feat(rust-server): refactor server module templates to avoid a monolithic run function.#23432
dsteeley wants to merge 1 commit intoOpenAPITools:masterfrom
dsteeley:refactor-rust-server-server

Conversation

@dsteeley
Copy link
Copy Markdown
Contributor

@dsteeley dsteeley commented Apr 2, 2026

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Refactors the rust-server generator to split the monolithic run() into per-operation handler functions, reducing compile-time memory and preventing rustc OOMs on large APIs. Behavior of generated servers and callbacks is unchanged.

  • Refactors

    • Added server-operation-handler.mustache to generate async fn handle_<operation>() per operation.
    • Updated server-mod.mustache and client-callbacks.mustache to include handlers; server-operation.mustache now dispatches to them.
    • Kept request parsing, auth, validation, and response mapping logic intact within each handler.
    • Regenerated Rust server samples to reflect the new structure.
  • Migration

    • No public API changes to generated code; existing implementations compile without changes.
    • No configuration or dependency updates required (hyper usage and behavior remain the same).

Written for commit 9bb4175. Summary will update on new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant